Re: [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc()

[Marc Zyngier <maz@kernel.org>]

On Fri, 03 Jul 2026 02:44:53 +0100,
Kemeng Shi <shikemeng@huaweicloud.com> wrote:
> 
> 在 2026/7/3 6:12:57, Marc Zyngier 写道:
> >> When its_irq_gic_domain_alloc() fails, the following
> >> its_vpe_irq_domain_free() skips calling its_vep_teardown() for the
> >> corresponding irq. Call its_vpe_teardown() when its_irq_gic_domain_alloc()
> >> is failedto avoid the leak issue.
> >>
> >> Fixes: 7d75bbb4bc1ad ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown")
> >> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> >> ---
> >>  drivers/irqchip/irq-gic-v3-its.c | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> >> index 3e4edcb64065..8968bedefdba 100644
> >> --- a/drivers/irqchip/irq-gic-v3-its.c
> >> +++ b/drivers/irqchip/irq-gic-v3-its.c
> >> @@ -4666,8 +4666,10 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq
> >>  			break;
> >>  		err = its_irq_gic_domain_alloc(domain, virq + i,
> >>  					       vm->vpes[i]->vpe_db_lpi);
> >> -		if (err)
> >> +		if (err) {
> >> +			its_vpe_teardown(vm->vpes[i]);
> >>  			break;
> >> +		}
> > There is already a spot for error handling in this function, we don't
> > need a second one.
> When its_irq_gic_domain_alloc() fails at index i, its_vpe_init(vpes[i])
> has already succeeded but the exisiting its_vpe_irq_domain_free(domain, virq, i)
> only tears down VPEs with index [0, i - 1], so its_vpe_teardown(vpes[i]) is still
> needed.
> So I guess you mean we can increase index when its_irq_gic_domain_alloc() fails to
> free the resource with existing error handling?
> Please correct me if I'm miss anything.

What I mean is this.

	M.
	
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index b57d81ad33a0a..4b1a3b497d7c4 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -4674,8 +4674,10 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq
 		irqd_set_resend_when_in_progress(irq_get_irq_data(virq + i));
 	}
 
-	if (err)
+	if (err) {
+		its_vpe_teardown(vm->vpes[i]);
 		its_vpe_irq_domain_free(domain, virq, i);
+	}
 
 	return err;
 }

-- 
Without deviation from the norm, progress is not possible.