From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC928003E; Fri, 23 Feb 2024 14:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698226; cv=none; b=nQY/5cgP1vnoKIFoiXVRFPMC9f8+FUP4VcebyaWI6lXTi148mIJDn4YpZaS1Me3k2UWJs9oVm9nPC2QiCpKDFQbrvr4Ct1lv9OJ44xPxJwgQ/f27ffItc4Vyh7UCla8+wd7pgFYANXDKLayP7JiHNPZ4BEJ7SxNobQQc61aICyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698226; c=relaxed/simple; bh=oG6lGxWEEemBwIFT+DyX89qfDgrB0Bkcpa14XrnC2Ks=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=N/nFFY1nqUamf3mNRbAr3ldvfc8YsOY39wfRNAaW+poqLYAULSMe6nqDPxifoT3Wi/HS6iXb2YF5v1yJTqeDH+3Q6DFIwNCcqmb0nyKA3sOJwT/f5w2CNLXm2F5XK9fcQWClfu93YNqzrexaynY1vR7Nk3oWGSdpuw18AS06pdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q3/aUvmv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q3/aUvmv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE849C433F1; Fri, 23 Feb 2024 14:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708698225; bh=oG6lGxWEEemBwIFT+DyX89qfDgrB0Bkcpa14XrnC2Ks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q3/aUvmvLzINogZY+JvkRDxgprMN4ZCuIBHfT85X/0fTg2sRO+Jvm6wLmvMo8z7Cc a3IIutESGxnmRYIr0S1djg5HZji8M/uNTk3Fxm6rorHLb19e7pVsZWrhgLmLM4pB4e Nyig2p/vY35Ln+VfjuSIGh2zgvbo/qI2J9S8XzN0J+ZI1pNH/SD+xKf2dATcNPLRBf xe3rlxJcRyM3v2dZ+4qm5eswOGOqCS+CZbtHLatve78QEsuWOHs5ucPi8J9y/Ize76 StUau5ku3dzKZulk13jo5MaExtKXz/oU3Ln24Qrx9BQ0Gmcha2BqWxHuf3Vv62rTOv xtbOug6ltAtVQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rdWSl-0066qh-Cf; Fri, 23 Feb 2024 14:23:43 +0000 Date: Fri, 23 Feb 2024 14:23:42 +0000 Message-ID: <86le7b2r9t.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , linux-kernel@vger.kernel.org, Eric Auger Subject: Re: [PATCH v4 00/10] KVM: arm64: Avoid serializing LPI get() / put() In-Reply-To: <20240221054253.3848076-1-oliver.upton@linux.dev> References: <20240221054253.3848076-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 21 Feb 2024 05:42:43 +0000, Oliver Upton wrote: > > Addressing a few more goofs that Zenghui was kind enough to point out. > Clearly all of the bugs have been found and addressed at this point. > > v2: https://lore.kernel.org/kvmarm/20240213093250.3960069-1-oliver.upton@linux.dev/ > v3: https://lore.kernel.org/kvmarm/20240216184153.2714504-1-oliver.upton@linux.dev/ > > v3 -> v4: > - Actually walk the LPI INTID range in vgic_copy_lpi_list() (Zenghui) > - Ensure xa_lock is taken w/ IRQs disabled, even after purging usage of > the lpi_list_lock (Zenghui) > - Document the lock ordering (Marc) This is looking good so far. I'll take it for a ride shortly, but in the meantime: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.