From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE890249E5; Fri, 22 Nov 2024 19:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732302508; cv=none; b=gZpaZ9qdnTNYVupiy8QF25rR4zcCfGwAcoT48hqwDO2+Fs17f68ygOjqLLyPbuQX1JFIgL2NKYDYAAmXTZWaLxFkuiuQfKw9K8JN/m9O6CtdWwtwZJcy35IWC/tsg7BMQ+3BEzl3FI8uJkVcaBBQlD4GFiS/IYwEc4frrzDhL3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732302508; c=relaxed/simple; bh=O9mDDediH4K4E/cTbRFrAHnx1KNidjn+4JetK3PhtQY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=DbDr2s1Wg/saoVJYRirdSONDIh2aR0VvWCRsAiNzy8nlDndoGzLlcBeAdmGlLcqInvmXuzqC4b5PoYP8AL1erZ6c9RCxXqi3luwpb6iEcWuOS7JYISLWfBQiMqlj6ldwQgAO0HiXkYvfk5yFGyBrBbeKrMk5BtHCxGrrQr7Ml18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bKsZps7S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bKsZps7S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4731DC4CECE; Fri, 22 Nov 2024 19:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732302506; bh=O9mDDediH4K4E/cTbRFrAHnx1KNidjn+4JetK3PhtQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bKsZps7SRth7q+3LtAkqruMDSvzvzJUb4Tnh52EWZieYmMSB8PikHHv41+wvwaXt1 cdYffmQMx0nLZqYSPLWmCJqUme3SnSpZirXtgY/2A+AUxfhBbcVIQbSqtIbpROXCaX kxdRMFiCUztajvOGdVinCVF6NLkNKPoRrwpIHWisNwt6ElS17MfklXMi6CwmxV/yy+ CGIH+KlnAcG9R4areBgr6hKDCa2W5hRMr9FoTtjd+zcnbmqnefVI8/x7cpz8EtS/at mKV7ATEXv8tIG8suawuDOBgLS/KQPILpDAwzyVN+mfxbravzLqQXRdvQvf9qDaG3L1 bFjy6KdoVnLXA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tEZ0x-00F6Cs-TH; Fri, 22 Nov 2024 19:08:23 +0000 Date: Fri, 22 Nov 2024 19:08:23 +0000 Message-ID: <86mshrulw8.wl-maz@kernel.org> From: Marc Zyngier To: James Clark Cc: will@kernel.org, kvmarm@lists.linux.dev, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Yicong Yang , Dave Martin , Fuad Tabba , James Morse , Mark Rutland , Anshuman Khandual , Vincent Donnefort , Quentin Perret , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: Fix usage of new shifted MDCR_EL2 values In-Reply-To: <20241122164636.2944180-1-james.clark@linaro.org> References: <20241122164636.2944180-1-james.clark@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: james.clark@linaro.org, will@kernel.org, kvmarm@lists.linux.dev, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, yangyicong@hisilicon.com, Dave.Martin@arm.com, tabba@google.com, james.morse@arm.com, mark.rutland@arm.com, anshuman.khandual@arm.com, vdonnefort@google.com, qperret@google.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 22 Nov 2024 16:46:35 +0000, James Clark wrote: > > Since the linked fixes commit, these masks are already shifted so remove > the shifts. One issue that this fixes is SPE and TRBE not being > available anymore: > > arm_spe_pmu arm,spe-v1: profiling buffer owned by higher exception level > > Fixes: 641630313e9c ("arm64: sysreg: Migrate MDCR_EL2 definition to table") > Signed-off-by: James Clark Huh, well spotted. This is doubleplusungood. Thankfully, the KVM/arm64 tree hasn't reached Linus yet, but this needs quick fixing. Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.