Re: [PATCH net-next 2/4] net: bridge: dsa: Add support for offloading of locked port flag

Nikolay Aleksandrov
2022-02-07T10:56:31Z

On 07/02/2022 12:07, Hans Schultz wrote:
> Various switchcores support setting ports in locked mode, so that
> clients behind locked ports cannot send traffic through the port
> unless a fdb entry is added with the clients MAC address.
>
> Among the switchcores that support this feature is the Marvell
> mv88e6xxx family.
>
> Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
> ---
> net/bridge/br_switchdev.c | 2 +-
> net/dsa/port.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>

Hi,
For some reason I still haven't received patch 01 which adds this new flag,
so I'll comment on this patch first.

These should be 2 separate patches, there is no bridge: dsa:.
Please break them into a bridge: and dsa: parts that add the flag, it also
makes it easier for people who have to backport patches and fixes later.

In addition please mention in the commit message why the flag is
added there, i.e. in order to allow to be offloaded.

Thanks,
Nik