From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CCC03126DD; Mon, 20 Oct 2025 12:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760962366; cv=none; b=bT2W42ZG87L5eEBGqvZnIm3Pyae39TAqzHN0xGtJaZALSJ/tlcYZLzNguSCcWVOB3yEeji3faECmV9iUDV9fCHqKghoD39WYQhzqchhZ8v/gV8ClXT/uOD7QH2bPEQXljcLf0g7tiiokbAaPeo4++H748NBHfKCoLP1ioKfqiRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760962366; c=relaxed/simple; bh=o627uAltlZfUSzxVftcBvs28qPkp2oEdWSS66lURXtI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=s5v05QJ7KUVebRgrCxYcfqtttx4bserqa5TUFJY9OOATLVMFiCStitNu0aXahYmB2neel9MCu+f59vamT+LbsBiwOAffTIiAp1ztwFtKCx3iOfzTXKGvH1dYADZZL/EbLLMvxez8CQpy+4CJoZKBcZ2BZMo4vR5423dn9C7aIF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h5F5cest; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h5F5cest" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC92C116B1; Mon, 20 Oct 2025 12:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760962365; bh=o627uAltlZfUSzxVftcBvs28qPkp2oEdWSS66lURXtI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h5F5cestvSoWmKsMxhDn02e47wX+MJ87BAGK0Y6phMV94r3eKHjrNEp1zZu+fxED7 YtxkBxbKhWddgKVmmwd+SgTGrZA1m6MtzgmiTGrgW5nVeqRBD2xNbT/AKlUnwGqwpK CxFnwwx1kh4zUaNUJbnalYeGJ+MRpObKKogEFXg0Qzhq3cd5vqpPj+lM7W8k/czdQF UlSDqdJ3Z3o59P76yGQDuN3Jn77G5kQg5tMKac+B2uZMMUb7YVJlEcI5mASJEh0A+o pomtK5I1U/9UyoElYQ9e4pNX/XF/jctqIhjg9HKiQi7ldFPJZfkE0ccU3onsqbGPNm QzvLIKHhqDaJA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vAokl-0000000FUSB-0FFU; Mon, 20 Oct 2025 12:12:43 +0000 Date: Mon, 20 Oct 2025 13:12:42 +0100 Message-ID: <86o6q1wz45.wl-maz@kernel.org> From: Marc Zyngier To: David Binderman Cc: "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , LKML Subject: Re: linux-6.18-rc2/arch/arm64/kvm/vgic/vgic-v3.c:728: Possible || and | mixup ? In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dcb314@hotmail.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 20 Oct 2025 12:12:33 +0100, David Binderman wrote: > > Hello there, > > Static analyser cppcheck said: > > linux-6.18-rc2/arch/arm64/kvm/vgic/vgic-v3.c:728:48: style: inconclusive: Boolean expression 'common_trap' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] > > Source code is > > if (group0_trap || group1_trap || common_trap | dir_trap) { > > Maybe better code: > > if (group0_trap || group1_trap || common_trap || dir_trap) { > Sure. please send in a patch. M. -- Without deviation from the norm, progress is not possible.