From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5781A8F84; Mon, 16 Jun 2025 17:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750093255; cv=none; b=mAYX43ZGIyyID2AyET8/h6kiGiJRFq5ff+qzCUKqsxlV+XxCdTC7teiYCyKJmrRAYRvs+tZ09aNQMJ+b8+5TiENN7dOM3jv/hVFjI01XPMro1FYkafQGi9S8N7b2BoAzPHYLjCVuYa3yb9jF+9MFL42BxiiroAUMjGH487PtqDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750093255; c=relaxed/simple; bh=w8kwfakgTDDq+gZlHITNqncq9RlH3vHKlobIKGrM2HU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=sDbR8Q5YEJlIr1mzeAm4ZOYJjexvMToGS0/E5nvjo+oA253Xefd9Ge7BxfYeL9Lpz3JeC0nb/UO1iC0zYFVIaeRTqK5iHyGhw37Lce+KiGhlZts7lMYzikbpPuAdn/DYb959UAk9sHvcJYX13xIXpOOb7EY7TnE28WbQNsPyeHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j+wz1jK1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j+wz1jK1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30221C4CEEA; Mon, 16 Jun 2025 17:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750093255; bh=w8kwfakgTDDq+gZlHITNqncq9RlH3vHKlobIKGrM2HU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j+wz1jK1RwBlSRkPRl6X9pdsDwe5fl7ilQFCi54NDyJ/JnFvvdsV2qj9MoAOJX5gA Hp5G10SkiKrJYlykC+fpR/zZANvcY1CbHYVAFyBLEf9yXHK774dBvMEayJ/jpCsMEp ozBtdY1Y76EXYSRTizbtlsm1ybSZbZbbHr00MVSKXIbFaRrzdax10ydqndUnp/r70A CB5dDvxpf5EMA8XOmRFQjg2mH2NYhObtL9Whyr+trTlCc1OxjJpHrVF7uly5a9G5ZV anXZVkI5dgTYxMkfofzrPDnI1Cce/7jYcODkVM2es86kqv+Z9Eimx4apFnsn3ToyR7 4dpvZF43h9UBQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uRDCW-007JGE-O0; Mon, 16 Jun 2025 18:00:52 +0100 Date: Mon, 16 Jun 2025 18:00:52 +0100 Message-ID: <86plf3d3jv.wl-maz@kernel.org> From: Marc Zyngier To: Wei-Lin Chang Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Jintack Lim , Christoffer Dall Subject: Re: [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put_nested() In-Reply-To: <2p4urq6ij5zq77c7viydmqqaj2doeyja43khvcjgn5pkpe7saz@eyfvuykscn22> References: <20250614145721.2504524-1-r09922117@csie.ntu.edu.tw> <86qzzkc5xa.wl-maz@kernel.org> <2p4urq6ij5zq77c7viydmqqaj2doeyja43khvcjgn5pkpe7saz@eyfvuykscn22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: r09922117@csie.ntu.edu.tw, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, jintack@cs.columbia.edu, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 16 Jun 2025 15:34:58 +0100, Wei-Lin Chang wrote: > > On Mon, Jun 16, 2025 at 11:54:57AM +0100, Marc Zyngier wrote: > > > +static u64 translate_lr_hw_bit(struct kvm_vcpu *vcpu, u64 lr) > > I believe translate_lr_pintid() better describes what this function is > doing. Ah, you too noticed that I am terrible at naming things? ;-) Agreed, this is a better name, and I'll gladly apply your suggestion. > > For everything else, I don't spot any issues after review. > > Reviewed-by: Wei-Lin Chang Thanks again! M. -- Without deviation from the norm, progress is not possible.