From: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: vamos-dev@i4.informatik.uni-erlangen.de
Subject: CONFIG_SCSI_G_NCR5380_MEM dead?
Date: Wed, 21 Jul 2010 15:01:14 +0200 [thread overview]
Message-ID: <86pqyhhtut.fsf@peer.zerties.org> (raw)
Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux'
configuration system.
I've been running a check on the drivers/scsi sourcetree for
config Items not defined in Kconfig and found such a case. Sourcecode
blocks depending on these Items are not reachable from a vanilla
kernel -- dead code. I've seen such dead blocks made on purpose
e.g. while integrating new features into the kernel but generally
they're just useless.
I encountered, that the CONFIG_SCSI_G_NCR5380_MEM symbol in
drivers/scsi/g_NCR5380.c isn't defined anywhere. So this codeblocks
seems to be unreachable. But there is a define in g_NCR5380_mmio.c for
SCSI_G_NCR5380_MEM with an include of g_NCR5380.c. So i think this is a
typo-bug and it should be a CONFIG_ define. The code wasn't changed since
linux is in git, so probably no one has used the mmio module, cause
there can't be a difference to the normal pio module. If you think this
ifdefs should be removed, i can send a patch.
Regards
Christian Dietrich
--
(λ x . x x) (λ x . x x) -- See how beatiful the lambda is
No documentation is better than bad documentation
-- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
next reply other threads:[~2010-07-21 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 13:01 Christian Dietrich [this message]
2010-07-21 13:12 ` CONFIG_SCSI_G_NCR5380_MEM dead? Ondrej Zary
2010-07-21 15:23 ` James Bottomley
2010-07-21 15:19 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pqyhhtut.fsf@peer.zerties.org \
--to=qy03fugy@stud.informatik.uni-erlangen.de \
--cc=James.Bottomley@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox