From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D013B3D62; Fri, 19 Apr 2024 10:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713523818; cv=none; b=n1mrUS4Udb2Wk9zf0e6Kc8fStH4DGq7uI/KOnFUw0CdVqT/BvGqdxjyPab4anvXP1rlUyMeYAR6sL0K2jVTRZqAFejjBDw0mnrS0pbx88YULHoRQZa5t5Frai8DaqNhUsw1dVVQUHeVXEp2uA8gTjXmKZ13e9FGFt3/j3+NW1DM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713523818; c=relaxed/simple; bh=eAPMP/cHU6KEqU8q+tfjHwFwP6sfACuYmS7UfdP3cxQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=AV52X/Xj05a43+owiQVDbDg1UmM87FuieLTRB5WrlLWDMvIjnVe+cz7R7ZOmdYJ4sOs4KthiKmmOnyTd5IBeaZjhrUdaV0SuXkMOt6IZ2GCu058fBWhb2D+qeSalvwDVJ1aIF0ZduW3Dh6k5Vo50u6kod9hJPhQI7RxoQXZvaDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rOID6TxS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rOID6TxS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 926BAC072AA; Fri, 19 Apr 2024 10:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713523817; bh=eAPMP/cHU6KEqU8q+tfjHwFwP6sfACuYmS7UfdP3cxQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rOID6TxSj8ICbmG3K2hSpxaiXsYmGuiUYyl/zAQPai4WarYIPm2FfuZJIBA22F4+Z iCCLbg3aPmnn9MnnZIx8bhopueXsMx35kH0ct3PT5VRpxfz+gri19dtL11YmD9915P uTRlb9b0sesXfz8z/cpg9Qr0+2TY6ttkJmq7gESUVgQ01Qz4BV4kVKiU2nLMKmubIB 3BxxJGefKXfpC+R99ZtwRgKYx760NUIzLefpMdp7l/ZBenY/Y7rIiEj8Sw0VMe+neh UHCZnmJHefmEsXIKBF0OaDwyyvsKu/HLZSPitNKNmuiB4EAl1Jd2nziXqQug2vFAr/ oAuqx1ueRjjeg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rxlot-0063Xb-Ei; Fri, 19 Apr 2024 11:50:15 +0100 Date: Fri, 19 Apr 2024 11:50:14 +0100 Message-ID: <86r0f1r5i1.wl-maz@kernel.org> From: Marc Zyngier To: Greg Kroah-Hartman Cc: Catalin Marinas , Naresh Kamboju , Mark Brown , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, Yihuang Yu , Gavin Shan , Ryan Roberts , Anshuman Khandual , Shaoqin Huang , Will Deacon , linux-arm-kernel@lists.infradead.org, Anders Roxell Subject: Re: [PATCH 6.6 000/122] 6.6.28-rc1 review In-Reply-To: <2024041921-drown-dizzy-7481@gregkh> References: <20240415141953.365222063@linuxfoundation.org> <86y19dqw74.wl-maz@kernel.org> <86sezjq688.wl-maz@kernel.org> <2024041921-drown-dizzy-7481@gregkh> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: gregkh@linuxfoundation.org, catalin.marinas@arm.com, naresh.kamboju@linaro.org, broonie@kernel.org, stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, yihyu@redhat.com, gshan@redhat.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, shahuang@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, anders.roxell@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 19 Apr 2024 11:40:33 +0100, Greg Kroah-Hartman wrote: > > On Thu, Apr 18, 2024 at 12:21:17PM +0100, Catalin Marinas wrote: > > On Thu, Apr 18, 2024 at 12:07:35PM +0100, Marc Zyngier wrote: > > > On Tue, 16 Apr 2024 18:28:10 +0100, > > > Catalin Marinas wrote: > > > > On Tue, Apr 16, 2024 at 02:22:07PM +0100, Marc Zyngier wrote: > > > > > On Tue, 16 Apr 2024 14:07:30 +0100, > > > > > Naresh Kamboju wrote: > > > > > > On Tue, 16 Apr 2024 at 16:04, Mark Brown wrote: > > > > > > > On Mon, Apr 15, 2024 at 04:19:25PM +0200, Greg Kroah-Hartman wrote: > > > > > > > > This is the start of the stable review cycle for the 6.6.28 release. > > > > > > > > There are 122 patches in this series, all will be posted as a response > > > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > > > let me know. > > > > > > > > > > > > > > The bisect of the boot issue that's affecting the FVP in v6.6 (only) > > > > > > > landed on c9ad150ed8dd988 (arm64: tlb: Fix TLBI RANGE operand), > > > > > > > e3ba51ab24fdd in mainline, as being the first bad commit - it's also in > > > > > > > the -rc for v6.8 but that seems fine. I've done no investigation beyond > > > > > > > the bisect and looking at the commit log to pull out people to CC and > > > > > > > note that the fix was explicitly targeted at v6.6. > > > > > > > > > > > > Anders investigated this reported issues and bisected and also found > > > > > > the missing commit for stable-rc 6.6 is > > > > > > e2768b798a19 ("arm64/mm: Modify range-based tlbi to decrement scale") > > > > > > > > > > Which is definitely *not* stable candidate. We need to understand why > > > > > the invalidation goes south when the scale go up instead of down. > > > > > > > > If you backport e3ba51ab24fd ("arm64: tlb: Fix TLBI RANGE operand") > > > > which fixes 117940aa6e5f ("KVM: arm64: Define > > > > kvm_tlb_flush_vmid_range()") but without the newer e2768b798a19 > > > > ("arm64/mm: Modify range-based tlbi to decrement scale"), it looks like > > > > "scale" in __flush_tlb_range_op() goes out of range to 4. Tested on my > > > > CBMC model, not on the actual kernel. It may be worth adding some > > > > WARN_ONs in __flush_tlb_range_op() if scale is outside the 0..3 range or > > > > num greater than 31. > > > > > > > > I haven't investigated properly (and I'm off tomorrow, back on Thu) but > > > > it's likely the original code was not very friendly to the maximum > > > > range, never tested. Anyway, if one figures out why it goes out of > > > > range, I think the solution is to also backport e2768b798a19 to stable. > > > > > > I looked into this, and I came to the conclusion that this patch is > > > pretty much incompatible with the increasing scale (even if you cap > > > num to 30). > > > > Thanks Marc for digging into this. > > > > > So despite my earlier comment, it looks like picking e2768b798a19 is > > > the right thing to do *if* we're taking e3ba51ab24fd into 6.6-stable. > > > > > > Otherwise, we need a separate fix, which Ryan initially advocating for > > > initially. > > > > My preference would be to cherry-pick the two upstream commits than > > coming up with an alternative fix for 6.6. > > To be specific, which 2 commits, and what order? That'd be: e2768b798a19 ("arm64/mm: Modify range-based tlbi to decrement scale") followed by: e3ba51ab24fd ("arm64: tlb: Fix TLBI RANGE operand") Thanks, M. -- Without deviation from the norm, progress is not possible.