Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI

[Marc Zyngier <maz@kernel.org>]

On Mon, 04 Dec 2023 08:47:49 +0000,
Jason Wang <jasowang@redhat.com> wrote:
> 
> On Mon, Dec 4, 2023 at 4:39 PM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Sat, Dec 2, 2023 at 8:20 PM Marc Zyngier <maz@kernel.org> wrote:
> > >
> > > Hi Kunkun,
> > >
> > > On Wed, 08 Nov 2023 09:45:51 +0000,
> > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > >
> > > > Hi Marc,
> > > >
> > > > On 2023/11/6 23:33, Marc Zyngier wrote:
> > > > > On Mon, 06 Nov 2023 14:59:01 +0000,
> > > > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > > >> The virtio-pci driver write entry1-6
> > > > >> massage.data in the msix-table and trap to QEMU for processing. The
> > > > >> massage.data is as follow:
> > > > >>> entry-0 0
> > > > >>> entry-1 1
> > > > >>> entry-2 1
> > > > >>> entry-3 1
> > > > >>> entry-4 1
> > > > >>> entry-5 1
> > > > >>> entry-6 1
> >
> > It looks like a bug from the driver. It should only use vector 0 and 1
> > in this case.
> >
> > Could you please check the queue_msix_vector for each queue in this case?
> 
> Or did you actually mean queue_msix_vector here? I'm not familiar with
> ARM but 0 doesn't seem to be a good message.data anyhow.

Why? What's special about 0? 0 is a perfectly fine value.

	M.

-- 
Without deviation from the norm, progress is not possible.