From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7BDC4167B for ; Mon, 4 Dec 2023 09:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343708AbjLDJAW (ORCPT ); Mon, 4 Dec 2023 04:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232342AbjLDJAS (ORCPT ); Mon, 4 Dec 2023 04:00:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD5C100 for ; Mon, 4 Dec 2023 01:00:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D406C433C9; Mon, 4 Dec 2023 09:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701680424; bh=Gt8qQX0dLBoE9A1NhesBli+9toqY41S3mdlGK2o31zc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ehcE4IcFZUD7pZB7iulQ0fpBf0Mlo8JQv+mrUqSTAyOj9fm/6a94Jol0kc2M8WqKG gS5IQ4tntoQUlCPgUxLI5ynkqggB+UQrELfBdO6cEArTcj4d9HopDRqxxXpnQumX7O LoTeiFa3Hnqjz02T3tm3V0SkAMpmrpx06J0UvuiScWI/3MVKehKx+3F9xKEpKWoZFZ dwIK89Nmjrlx1FVg1VE3fcCok8GnMlZ5bH9JNL42yhFndfnxkYVzAul9bvHhx85f+v djAliMwgBMG7ZcvPTGEli7Fz5u1IF2kMdKn6B32z5YxE3qZ9QJmoHDPvm5szSMxuyB TzGebDC9D+sig== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rA4oP-0019X3-Ly; Mon, 04 Dec 2023 09:00:21 +0000 Date: Mon, 04 Dec 2023 09:00:21 +0000 Message-ID: <86r0k2bavu.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: Kunkun Jiang , dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Gavin Shan , Jean-Philippe Brucker , "open list:IRQCHIP DRIVERS" , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI In-Reply-To: References: <20231102143507.840-1-jiangkunkun@huawei.com> <87msvt6cc7.wl-maz@kernel.org> <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com> <86edh228xx.wl-maz@kernel.org> <952bd5dc-dd20-acc3-d77e-c9b14e5728d3@huawei.com> <87fs0k94og.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jasowang@redhat.com, jiangkunkun@huawei.com, dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, gshan@redhat.com, jean-philippe@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Dec 2023 08:47:49 +0000, Jason Wang wrote: >=20 > On Mon, Dec 4, 2023 at 4:39=E2=80=AFPM Jason Wang w= rote: > > > > On Sat, Dec 2, 2023 at 8:20=E2=80=AFPM Marc Zyngier wr= ote: > > > > > > Hi Kunkun, > > > > > > On Wed, 08 Nov 2023 09:45:51 +0000, > > > Kunkun Jiang wrote: > > > > > > > > Hi Marc, > > > > > > > > On 2023/11/6 23:33, Marc Zyngier wrote: > > > > > On Mon, 06 Nov 2023 14:59:01 +0000, > > > > > Kunkun Jiang wrote: > > > > >> The virtio-pci driver write entry1-6 > > > > >> massage.data in the msix-table and trap to QEMU for processing. = The > > > > >> massage.data is as follow: > > > > >>> entry-0 0 > > > > >>> entry-1 1 > > > > >>> entry-2 1 > > > > >>> entry-3 1 > > > > >>> entry-4 1 > > > > >>> entry-5 1 > > > > >>> entry-6 1 > > > > It looks like a bug from the driver. It should only use vector 0 and 1 > > in this case. > > > > Could you please check the queue_msix_vector for each queue in this cas= e? >=20 > Or did you actually mean queue_msix_vector here? I'm not familiar with > ARM but 0 doesn't seem to be a good message.data anyhow. Why? What's special about 0? 0 is a perfectly fine value. M. --=20 Without deviation from the norm, progress is not possible.