From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5831DFCB for ; Fri, 1 Aug 2025 12:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754051437; cv=none; b=nKlmN3YDr7JMUunfivHpJrRunfLTbCCE9xOJnIJlhLkB8Vy9gvUdsS64SGS7caT1beNn4ubcueLvetGfXEMEIIn2Y259ePmShhE72MzC5VCji0hsN3/kJF7oWE9nyn2XUWSDCJC2fTvY1+cjOsqxqDqvTdP30aQpmZ4ZIcZxyjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754051437; c=relaxed/simple; bh=/ggtNs5ogUeCOWKk2L9VN+ED68QrwSUCjumblqjB2Xo=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Xbt2o6sT5MuAspEl+oRJoRFFXYTB3NCLruKBjpgBWj7q1d8mW0PADOVFvWio75EfDOjFaMQ6clwHlCICqTrGfHruzPfksgloPPKF27XRD97eFBus7pHvfGsSfKheuku/NWJq4xmcDghvmXmH94MHVd9eQAwOlVwU5hi70OMautA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R4ZyqggH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R4ZyqggH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EE8C4CEE7; Fri, 1 Aug 2025 12:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754051435; bh=/ggtNs5ogUeCOWKk2L9VN+ED68QrwSUCjumblqjB2Xo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R4ZyqggHDWuR+bOXski8PyPOwbafzu9eJ7h/Tg96yzHvHZRFp2UrDFKQXqXYhjVnk v10mDHCfiADKT3XQbbQfur428+DQ36J9F/wixs77a/hpnyULjK+IL+eAueVMJco6q5 ut0Y8Oe/SY0eN1NxiQAdQy5fJfN5AkKyu2to3kB9999U69s8we1iySwFm5Xna5qbAY AKdqAnaBDJX0FeWAg/SUmWXIfd7VBUFWfzK2bFjDi6DPm1yQkFVd4sRsZ5+nZRdlKs G8plduAQd1eT9kRq6dVpQ+ORstVfkqXKR5ZcW03FU2qO3jDZ67sAdpD3s10PLDpZ7W XDo2LzAVUoTRw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uhou9-003C78-HR; Fri, 01 Aug 2025 13:30:33 +0100 Date: Fri, 01 Aug 2025 13:30:32 +0100 Message-ID: <86seib6x7b.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Thomas Gleixner , Sascha Bischoff , Timothy Hayes , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] irqchip/gic-v5: Remove IRQD_RESEND_WHEN_IN_PROGRESS for ITS IRQs In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-3-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> <20250801-gic-v5-fixes-6-17-v1-3-4fcedaccf9e6@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, tglx@linutronix.de, sascha.bischoff@arm.com, timothy.hayes@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 01 Aug 2025 08:58:20 +0100, Lorenzo Pieralisi wrote: > > GICv5 LPI interrupts have an active state hence they cannot retrigger > while the IRQ is being handled. > > Therefore setting IRQD_RESEND_WHEN_IN_PROGRESS for GICv5 ITS > interrupts provides no benefit and it is useless (and confusing), > it solves an issue that cannot happen. This doesn't read very well. How about: "Therefore, setting the IRQD_RESEND_WHEN_IN_PROGRESS flag on LPIs is pointless, as the situation this flag caters for cannot happen". > > Remove it. > > Signed-off-by: Lorenzo Pieralisi > Cc: Thomas Gleixner > Cc: Marc Zyngier > --- > drivers/irqchip/irq-gic-v5-its.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c > index 340640fdbdf6..9290ac741949 100644 > --- a/drivers/irqchip/irq-gic-v5-its.c > +++ b/drivers/irqchip/irq-gic-v5-its.c > @@ -973,7 +973,6 @@ static int gicv5_its_irq_domain_alloc(struct irq_domain *domain, unsigned int vi > irqd = irq_get_irq_data(virq + i); > irqd_set_single_target(irqd); > irqd_set_affinity_on_activate(irqd); > - irqd_set_resend_when_in_progress(irqd); > } > > return 0; > With that, Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.