From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3050C2356BB; Thu, 17 Apr 2025 11:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744888259; cv=none; b=RLXtI+tpHioxFimnG4FyYCGw86XR4OaLlmLCkBDRruLRETK5N4pEaRn2cwJIx25ZaYRw+/73A2ZtNObkzvcnlIkiDekIxaXkoliosZpF0QCWYQkyhmj4zepSfFuRV94rbdUM5QobmR/dPPl2R+HeLmaOwQrL8CIAFmHyE7z/CeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744888259; c=relaxed/simple; bh=fEBqhxlmx82BtM/AlDZZ5wzx7wCNw1G9R+pxLG8DyL8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=SxesTiBJX3hP6wqo79tnKDBDMDSN+fJvDrglIhwxyVxrto98jpPHfMnoZkvZWMZSNM0FVVuFNQO1vtwKzBUMBcKD55fPYL7DHlaf16j7NMF24PUi4Nb5pAYsdeXldbEKPSClt8iBCVPWlo5QAQ6Mj4uedCHrPgr13wOTnBa1+Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zwe8MN7g; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zwe8MN7g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB080C4CEE7; Thu, 17 Apr 2025 11:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744888258; bh=fEBqhxlmx82BtM/AlDZZ5wzx7wCNw1G9R+pxLG8DyL8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zwe8MN7gY9/fyNSI6M4egF4DqTK6cOa74cIgePtVm5SxlHrH+BFGILB3SU+THyiY4 Y5zhBRJoX5lB6AJEvE2UyTUvrVAQQWJQpG5QB+/oxiv85AL6oeI7Ef3KZAX6LHi03p 3UcOsaKtnGf6MlDb9qqcOJYbWNLKJYBOa6HGAuh149UD5wQrwIa7APBHfo57SolIPz iuEmJavhra38nemTtJ9MJyy41GvkjLD3zSJpPTiuWJA+/HCIrte5XzncA7QeFyTe12 /LfO983iZHYkOPkerszOlBINL8FzDe75AdGD155w/tvxk8A1h12DUOJiYNKqGYoXsm S648FervPhCuA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1u5N8y-006ONV-Cd; Thu, 17 Apr 2025 12:10:56 +0100 Date: Thu, 17 Apr 2025 12:10:54 +0100 Message-ID: <86sem7jb5t.wl-maz@kernel.org> From: Marc Zyngier To: Luo Jie Cc: Yury Norov , Rasmus Villemoes , Julia Lawall , "Nicolas\ Palix" , Catalin Marinas , Will Deacon , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , , , , , , , , , , Subject: Re: [PATCH v3 0/6] Add FIELD_MODIFY() helper In-Reply-To: <20250417-field_modify-v3-0-6f7992aafcb7@quicinc.com> References: <20250417-field_modify-v3-0-6f7992aafcb7@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: quic_luoj@quicinc.com, yury.norov@gmail.com, linux@rasmusvillemoes.dk, Julia.Lawall@inria.fr, nicolas.palix@imag.fr, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, andrew@lunn.ch, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 17 Apr 2025 11:47:07 +0100, Luo Jie wrote: > > Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield > macros. It is functionally similar as xxx_replace_bits(), but adds > the compile time checking to catch incorrect parameter type errors. > > This series also converts the four instances of opencoded FIELD_MODIFY() > that are found in the core kernel files, to instead use the new > FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding > the script field_modify.cocci. > > The changes are validated on IPQ9574 SoC which uses ARM64 architecture. We already have the *_replace_bits() functions (see include/linux/bitfield.h). Why do we need extra helpers? M. -- Without deviation from the norm, progress is not possible.