From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 401CD3C3C for ; Tue, 16 Jul 2024 10:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721124957; cv=none; b=pW5sKDaHxarnifcnFn/eWcMN9wWZp9+4f006I/Clr/4oCsYs15uJ10F8+jhWuwLExNU64ma8HxxBtCD3Fv5tbGzxGpVMxoi/rlMcUxmMnTWPeDPCu2dLtR6lYBnnyqjs+ukDQeWYnXFOMeLSdaAhqTlnEZRw5RzxYQfyPdJ9LAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721124957; c=relaxed/simple; bh=zx/kmfbSdkW60LRZzv8UQf1UvQghFy9v1bu72O53pYE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=YvBrnhwA07cRRPV+0a5Pdyj9OOVcVpOSJV3yck8Pe7sc93sg6YJj8vlgVw3uO3eo3j/kOuvqgK4M6kQl6AzVxum221BXMwr9LwVZvCt+CMF3Xn4UdiOgpvb2Kl8SQxArsuS0yM25z1z/KhYoa6EJXlEW5MfkYFlAU7KhtZAwW7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QPks1EQ7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QPks1EQ7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14B31C116B1; Tue, 16 Jul 2024 10:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721124957; bh=zx/kmfbSdkW60LRZzv8UQf1UvQghFy9v1bu72O53pYE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QPks1EQ7nVUveJ7IbrGLBhHZk5ovTbNef9y2HoZBwX+jiR9SyeSy6t2rhbStVNBq4 4npCVe5HVqb+yLSZopJjFTKZTCBKkxC2O9xmurWI1PfXMfu+jevDXLe11B5ClgNOWF 1aTwbBSnd1dDMLJq/b3J8uA0mr0gHHCbhSKL2mQ3SjJ6fKt8fyBZEh7Zllthk25KBX MTsS+x5ZkkUWOrK9rMrT+guo8ZSrDRnZEiBkz/POkxvX492Q3UM7XPYVtYdzQ2ngmT ZSs0BknlQ+2P16bd7poOXpTcMD7s59pFhke6CL7KgcjIX3S84XF52TxdTRu6ZsOaLm VAoYW2mwXocTA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sTfDu-00ClWB-ST; Tue, 16 Jul 2024 11:15:55 +0100 Date: Tue, 16 Jul 2024 11:15:54 +0100 Message-ID: <86sew93an9.wl-maz@kernel.org> From: Marc Zyngier To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Nicolas Schier Subject: Re: [PATCH] kbuild: deb-pkg: Fix build error caused by lack of positionnal argument In-Reply-To: References: <20240710172717.1346194-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: masahiroy@kernel.org, linux-kernel@vger.kernel.org, nicolas@fjasle.eu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 16 Jul 2024 08:06:06 +0100, Masahiro Yamada wrote: >=20 > On Thu, Jul 11, 2024 at 2:27=E2=80=AFAM Marc Zyngier wro= te: > > > > Since 8ef052389f7f ("kbuild: package: add -e and -u options to some > > shell scripts"), building a debian package on my arm64 box fails: > > > > $ make -j20 bindeb-pkg > > UPD include/config/kernel.release > > GEN debian > > ./scripts/package/mkdebian: 138: 1: parameter not set > > make[2]: *** [scripts/Makefile.package:98: debian] Error 2 > > make[1]: *** [/home/maz/hot-poop/arm-platforms/Makefile:1538: bindeb-pk= g] Error 2 > > make: *** [Makefile:224: __sub-make] Error 2 > > > > Applying the same pattern for substitution of undefined variables > > seems to paper over the issue and brings the script back to life. > > > > Fixes: 8ef052389f7f ("kbuild: package: add -e and -u options to some sh= ell scripts") > > Signed-off-by: Marc Zyngier > > Cc: Masahiro Yamada > > Cc: Nicolas Schier > > --- > > scripts/package/mkdebian | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian > > index 196b14e8ad47..de8b460a46b4 100755 > > --- a/scripts/package/mkdebian > > +++ b/scripts/package/mkdebian > > @@ -135,7 +135,7 @@ else > > fi > > maintainer=3D"${name} <${email}>" > > > > -if [ "$1" =3D --need-source ]; then > > +if [ "${1:+set}" =3D --need-source ]; then > > gen_source > > fi > > >=20 >=20 > This is wrong. >=20 > It will break 'make srcdeb-pkg' because > "set" =3D "--need-source" is always false. >=20 >=20 >=20 > I will squash the following. >=20 >=20 > while [ $# -gt 0 ]; do > case "$1" in > --need-source) > gen_source > shift > ;; > *) > break > ;; > esac > done >=20 >=20 > Thanks for the report. This seems to work for me. M. --=20 Without deviation from the norm, progress is not possible.