From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CB9B3DDDCD; Tue, 19 May 2026 07:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779177240; cv=none; b=SI8Fxy02EAyifDYl4s0v/D9Wtrrvka5GfRed7Tc8s7+9gXaX6yb+lNYMbum8oQGAsw/W5zE5G/TdDFe0e8airn6Hssmg9wFHkZWHMmyNQZZ4yTPPm3lnNL82zqNimneCmLq3OxZpqdVL4ob6q5CUqkca8ab2Js9vVVcFufedrC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779177240; c=relaxed/simple; bh=dE1+5CTzbd3ruwSwP8Km4ilvTVIBMQhESJGdZiggQi4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=iyITeLEuBxrEYsE/5fEqD0ZmM7kYYE/MTnZ+mgsuQ35ay0VbqILvXmbYKdUsdLG8xiSDS80Sp4rYLrH3AF1C6C2ox5EXG/yecaxld6vz++4jo4mz5W9EhHYG29swTbD4fNOfAUYzMNT97KXtnq4q0Mog5IwEIB2iAB4Bx2Uq0bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y0ENtzoe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y0ENtzoe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F2AC2BCB3; Tue, 19 May 2026 07:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779177239; bh=dE1+5CTzbd3ruwSwP8Km4ilvTVIBMQhESJGdZiggQi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y0ENtzoe4SvmuJQ3CilFHTbmlNa15I5+Oaw3k9Ddjw+Fq+CmhOi8EDHe5vhUFzjzu 4nGyHfS2QdvcVf81R5I13sTkIwdcQdpX3TNrJXZN9XmuoVQlfrXphttBN4475DnR4W JUw0biK/q5Cfuf4CNx9g5O6CGnI88qiRSavRAGw9FjKhpyL4boRYNL0h2Xm9a4smaK potBWRIs/y7qDvjfpRdTllIp22ovZTEs9cpkYqwSuBusk0f8KsH9lznSgQMj8OdLZ3 W1yGjIFWbzZRcZGH86Aa6WqDQ9nKDXFPI4efgB5FXzirK2i0SUTbDkwwJYsYltblcz hnuq04ZQCeFOw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wPFH3-00000003poq-0yUd; Tue, 19 May 2026 07:53:57 +0000 Date: Tue, 19 May 2026 08:53:56 +0100 Message-ID: <86tss3x2az.wl-maz@kernel.org> From: Marc Zyngier To: Michael Bommarito Cc: Yao Yuan , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic: free private_irqs when init fails after allocation In-Reply-To: References: <20260517181331.367676-1-michael.bommarito@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: michael.bommarito@gmail.com, yaoyuan@linux.alibaba.com, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 19 May 2026 01:26:58 +0100, Michael Bommarito wrote: >=20 > On Mon, May 18, 2026 at 1:31=E2=80=AFAM Yao Yuan wrote: > > Ah. One thing I forgot to say: > > > > Do we need a fixes: tag here ? >=20 > I struggled with that a bit. Will's sister commit in 250f25367b58 > didn't have a Fixes: tag, but if I had to pick, it would probably be > this: > Fixes: 03b3d00a70b5 ("KVM: arm64: vgic: Allocate private interrupts on de= mand") >=20 > If you agree, I can send v2 with that added Seems correct to me. Please send v2 at your earliest convenience with a trimmed commit message (potentially limited to the first paragraph). Thanks, M. --=20 Without deviation from the norm, progress is not possible.