From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0312E1C7013 for ; Fri, 1 Aug 2025 12:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754051207; cv=none; b=DPMEx3o7yUE4h3BFiE9QwdU4xrjmCQPgUWmlU1kvZBy55QWNbbP4qWziMek7NwflZosUZ5fa7Or1mzvH8KXJ+DxvVueBHg8hqFH7c45hv/LeQl4m7Vvk46GDKo7edpR1f79+yCwXV3a+Dl7yj14TcfVvzTMdPu4IG1UiwQSBMhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754051207; c=relaxed/simple; bh=54omA8gQjQ0nB3x6U7tnPOT4PBWXGy4soqSWYNK0+ks=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=lTYv0xcgpwy10PcixIlY0VLCudssfqan3o9B2h0QDgdfnrjII7/nDrzG+zW26P5P6oq8wwMbfeg/Mu5pn8O4LM39Qp2smWRvsGGVqDoFcEddUyDHt1Mu7p0W+drnZhrZHqjBTWjD+BDekky/4BCSCUoQr+hsMvn8R+pZFijUsGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P0n6ciKf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P0n6ciKf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C47EEC4CEE7; Fri, 1 Aug 2025 12:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754051206; bh=54omA8gQjQ0nB3x6U7tnPOT4PBWXGy4soqSWYNK0+ks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P0n6ciKfDp3a+nZAH31xqpZfMLuq7M7ajQS/LqXvKygMG/NdOQzeOaBTCXo9lu5qF FXQC8qjQh7Y7HDtdYrRm7vcDOiV6Vm0Ii2xt6VVkpAUQxUhkI06UFdGDD7UreVJ+L+ ZSDNWLjAGbtUWj14sdjOLMbBQgECeCDkLbEp50qkMYr7XXkgpTxYOoyMbmmA6Mtjvp IpeHOnOw08oZ3uNfRHCJdl8ufJ91nfDf6XYdcguJg3T11Jm0Hj2IafzisiCoZegCyZ 4nnJTcqCPUV/hVawtZIJ0EHD7OfrbS6MfSoSHzgg4gNpg48kLTcQwMat7tjnVg9Zoe 14TBCY0bJGNpA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uhoqS-003C3U-Ds; Fri, 01 Aug 2025 13:26:44 +0100 Date: Fri, 01 Aug 2025 13:26:42 +0100 Message-ID: <86tt2r6xdp.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Thomas Gleixner , Sascha Bischoff , Timothy Hayes , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, tglx@linutronix.de, sascha.bischoff@arm.com, timothy.hayes@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lkp@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 01 Aug 2025 08:58:18 +0100, Lorenzo Pieralisi wrote: > > Kbot reported that on the failure path the driver > iounmap() IWB resources that are managed through > devm_ioremap(), which is clearly wrong because > the driver would end up unmapping the MMIO > resource twice on probing failure. > > Fix this by removing the error path altogether > and by letting devres manage the iounmapping > on clean-up. > > Fixes: 695949d8b16f ("irqchip/gic-v5: Add GICv5 IWB support") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202508010038.N3r4ZmII-lkp@intel.com > Signed-off-by: Lorenzo Pieralisi > Cc: Thomas Gleixner > Cc: Marc Zyngier Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.