From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B3E2D3EFC; Fri, 27 Jun 2025 13:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751030594; cv=none; b=OsJrhv0KxuEXD0KF7QsUKsx+T8CdyNdMztZr4GbihcY1lxpEmAbS46BewQzCLxw4FenRcp2j7VrT5ETj39SLoX4rqPXcm2lB5WhObnAb8aIDTqug74AKq+JzJX2TIR7yVwJ2IRJusOKn7WMRlpJUBU6HK1hFyudicUbMiDFNhzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751030594; c=relaxed/simple; bh=JIWvjEsAlcLjXPQ5Hbwf/8w/8yueo94WJUdb35S5Oec=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=rie078NN9vnOpV+qFzpgcBwJ8qIce6hfgRkc3lKGjOfvhIBs4GNjqtwYDZ/wljdjvw9bFOF0YjHqtabeIra5NNEpjU9NBUqe+CEcPtJvyHpvkoKJr35TjRwHLgVx35Htg0ylycOmgYeiLZFyRt5DbcTarMYZbHYAFM1RQwtRP3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vOYFNiTv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vOYFNiTv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F526C4CEE3; Fri, 27 Jun 2025 13:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751030593; bh=JIWvjEsAlcLjXPQ5Hbwf/8w/8yueo94WJUdb35S5Oec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vOYFNiTvT+uN16eqP2YsWAm8KNoGDrAGRnGCZQ6k3cO3wSmWrl36/2ZlQcLJQwrRv x0ukPV/wQEOdYQ2i6vAzxBPDpSXvXf3bfojfbaXAGUi/zOjkFrXqpF4lL5XnmLTOA8 JVICb6C+MRm1Siz8dIurqz6weeho1YZXN5VTyqQEoGulA/8dV9I2M2O6Lh80RiFBlv a8PqNGgBVGPdfZSr5Bsa2an5D5s9mwpT/qmHwp6N2Dnb8r+rq0pfYtC4MB++kkgB64 exk69s0EgLMe7xEvIINLL9QNOlx2iQzFmmNXVv1jZa2st1kUxL05Mes900+mRzbxlL UwcCAULbWT0Qw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uV92s-00AZW6-S1; Fri, 27 Jun 2025 14:23:10 +0100 Date: Fri, 27 Jun 2025 14:23:10 +0100 Message-ID: <86tt41b9oh.wl-maz@kernel.org> From: Marc Zyngier To: Colton Lewis Cc: kvm@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Russell King , Catalin Marinas , Will Deacon , Oliver Upton , Mingwei Zhang , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mark Rutland , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 02/22] arm64: Generate sign macro for sysreg Enums In-Reply-To: <20250626200459.1153955-3-coltonlewis@google.com> References: <20250626200459.1153955-1-coltonlewis@google.com> <20250626200459.1153955-3-coltonlewis@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: coltonlewis@google.com, kvm@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, mizhang@google.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, shuah@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 26 Jun 2025 21:04:38 +0100, Colton Lewis wrote: > > There's no reason Enums shouldn't be equivalent to UnsignedEnums and > explicitly specify they are unsigned. This will avoid the annoyance I > had with HPMN0. And randomly break unsuspecting cases for which a value is neither signed not unsigned, but an actual *enumeration*. If you have issues with HPMN0, start by explaining those, because ranting in a commit message doesn't help much. M. -- Without deviation from the norm, progress is not possible.