From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12693770EE for ; Fri, 31 May 2024 09:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717147627; cv=none; b=nGfCD91Ta91wHFXjfhCvRLcZpT9cNWyJPG7sWuUN+5r56yqamGXCGVaVPG/a2yG2RQ3aeUfOW8kDlUU4ZnG2jylEnOnnb1VKcrIkPxP2s7+2xziWv1LLLKhgeAYlpRvmm7TnFoW0/117RUr4/pPodV8h7aA2sk/e6h0Ua3qbXNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717147627; c=relaxed/simple; bh=a7wmDqmUfEy4sWh4SogWxUyxjOiHWPHOFeUWeU5qm9I=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=TbTOBwxgXzsleI/DsLZUuC3iu0077qZrSeuKWjYzPD5TaC4xHhEFGLxGyd3X06k0K56wqKScGBeZay+uutyv3sPMpjqiHekaGCSgXXEDxufBMkVvqN7BBJGOz0+UPDBcNdOouJ7EcX+yPWmJrBYqK7sMjRPrKNRpT5w3JEk/WuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s15xrfFB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s15xrfFB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1450C116B1; Fri, 31 May 2024 09:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717147626; bh=a7wmDqmUfEy4sWh4SogWxUyxjOiHWPHOFeUWeU5qm9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s15xrfFBXLLa2OztA12J9cnSuK2dOlgh+od2sYYyavwU33qQ78WmvBa0HEUaDWP91 4yuOGl4/jwg2hP44S7KlhweiIDfe0f8fD34F21730fL6gKBTZSU2b/FF4M77w0ZK6a 2HZBPZWgqptJKEzdK0XVksSPVvs6YBgWWUcbZEGjkzez1BGf3MKqaem5SuTO9l4/6y N2kr97V2NUfm1wlUPnXD/wvIdujAp0LVXrf4EyegofsVMA1dLBqNQ1FiM+p0/HizOl 2DK6CXaFF7n4Cpdlx/+6xlU3cJgQhmcTE+A3ZAv4VpdToWYLueaIWlg8jLIyniV5Cb XoYwT2nOWI0ug== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCyXQ-00H83j-Fj; Fri, 31 May 2024 10:27:04 +0100 Date: Fri, 31 May 2024 10:27:04 +0100 Message-ID: <86ttiel4bb.wl-maz@kernel.org> From: Marc Zyngier To: Hagar Hemdan Cc: Maximilian Heyne , Norbert Manthey , "Thomas\ Gleixner" , Eric Auger , , Subject: Re: [PATCH v2] irqchip/gic-v3-its: Fix potential race condition in its_vlpi_prop_update() In-Reply-To: <20240531074302.30563-1-hagarhem@amazon.com> References: <20240531074302.30563-1-hagarhem@amazon.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: hagarhem@amazon.com, mheyne@amazon.de, nmanthey@amazon.de, tglx@linutronix.de, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 31 May 2024 08:43:02 +0100, Hagar Hemdan wrote: > > its_vlpi_prop_update() calls lpi_write_config() which obtains the > mapping information for a VLPI without lock held. So it could race > with its_vlpi_unmap(). > Since all calls from its_irq_set_vcpu_affinity() require the same > lock to be held. So instead of peppering the locking all over the > place, we hoist the locking into its_irq_set_vcpu_affinity(). > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Fixes: 015ec0386ab6 ("irqchip/gic-v3-its: Add VLPI configuration handling") > Signed-off-by: Hagar Hemdan Given that you have lifted both my proposed patch and part of my reply as a commit message, you may at least credit me with a Suggested-by: tag. Not to mention that the blatant advertising doesn't really apply in this case. > --- > v2: moved the lock to its_irq_set_vcpu_affinity(). > Only compile-tested, no access to HW. Was the initial patch tested at all? M. -- Without deviation from the norm, progress is not possible.