From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CC2C77B7F for ; Fri, 12 May 2023 08:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240046AbjELINM (ORCPT ); Fri, 12 May 2023 04:13:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232659AbjELINL (ORCPT ); Fri, 12 May 2023 04:13:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1818B90; Fri, 12 May 2023 01:13:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0E7D653D1; Fri, 12 May 2023 08:13:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9BAAC433D2; Fri, 12 May 2023 08:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683879189; bh=m1euRqMgVsjyk/hdBGoy5f5fgkvAas5oq/SZ62tuH5w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PXlOLPfi44JB46KLHSytBwdeX7wA5gm0xjBJhDjBjIlc4ULtUmI99+FgEsASVThyX gKjAelxQ+zmg21q3r89HuEnUDYVN3Vr6S2cV2mUmnfm0g//7o3S5Eid3aGiK4/x+7z O4a+w42aJoJL/Q+msF4PVgJ7kAYx43DqPLCs3Zp1MVf+dvteaXznMw/ctXHsr4JYbh jtNqN1qhh1b3f3i1ftray64Xj3fMeqzCyFK1h+NDvkYZtJc3u7OgOdmwYaOyXzGl0z nFX17DphF7fvleD8EYAVT1C9D16XNSJzEePzFdMYtKuWJqkqp65HlK1ZAZzLagIT2X JpL78kesdq4uQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pxNti-00EVyX-Fr; Fri, 12 May 2023 09:13:06 +0100 Date: Fri, 12 May 2023 09:13:06 +0100 Message-ID: <86ttwim0h9.wl-maz@kernel.org> From: Marc Zyngier To: Douglas Anderson Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Conor Dooley , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] arm64: dts: mediatek: mt8183: Add mediatek,gicr-save-quirk In-Reply-To: <20230511150539.3.I525a2ed4260046d43c885ee1275e91707743df1c@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> <20230511150539.3.I525a2ed4260046d43c885ee1275e91707743df1c@changeid> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dianders@chromium.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, eddie.huang@mediatek.com, allen-kh.cheng@mediatek.com, Ben.Ho@mediatek.com, weiyi.lu@mediatek.com, angelogioacchino.delregno@collabora.com, linux-arm-kernel@lists.infradead.org, tinghan.shen@mediatek.com, jwerner@chromium.org, hsin-hsiung.wang@mediatek.com, yidilin@chromium.org, seiya.wang@mediatek.com, conor+dt@kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 23:05:37 +0100, Douglas Anderson wrote: > > Firmware shipped on mt8183 Chromebooks is affected by the GICR > save/restore issue as described by the patch ("dt-bindings: > interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ > broken FW"). Add the quirk property. > > Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5169779d01df..39545172fce5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -709,6 +709,7 @@ gic: interrupt-controller@c000000 { > <0 0x0c400000 0 0x2000>, /* GICC */ > <0 0x0c410000 0 0x1000>, /* GICH */ > <0 0x0c420000 0 0x2000>; /* GICV */ > + mediatek,gicr-save-quirk; Is that something you can safely generalise at the SoC level? Are these SoC solely used on Chromebooks, and/or without any hope of seeing any alternative FW being already in use? M. -- Without deviation from the norm, progress is not possible.