From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852AF3932F0; Mon, 10 Aug 2026 07:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348696; cv=none; b=dCptdKq6ZmEhO1hSdZEYYaJlbGPnu65BL/92MySkOlj8g2rOntXqTSv0QOo2hdOMjniC2T+tDixTgSWkwD/QH7W/5iFxzFW6rz1dAzi672lm1UE4uXwIJkk7Gqr2+qistlWsSUpTI5kY5HNcxPJ9wjYsrrjK84QIbiytSB6/Qk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348696; c=relaxed/simple; bh=+SeTgwlSWQG3kjrVtFNUnUOtvD5m8CZ2IDZ3hBZWDTM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ftaBxwlNh1chk2jUwxlLc9T45/gU4U4gyjCBeoLngin7q9tkZuRpKOc7zcKQKaLyCObpYUjsCRQ/tKwrhllEL3HAQFOCMAzu7lMDqYr8YQpbtiDEEciREGh4D5EG+IfBGrY4v/SHy7EW2riNWAV77HLeuhC4tU0ghf+BEUVfIGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=COBlg/Sl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="COBlg/Sl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 263501F000E9; Mon, 10 Aug 2026 07:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786348695; bh=BsrZgEPc2Pn2495B+7qWiG1MH6NX6fq3RoIYaYJSwbo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=COBlg/SlREcQLyiZEww21V0aG2nsJRNCphK3pPIw4lxaNV0jwHv1h6dCaPqSWec28 aa2HT25jSnBZP1poQSM/Zo9tpzDMm2V+vtu88mUHd3R4yFtAuwRyU+k2s+A8E3rx6T sZXRdiIRCleStXCHC3T9jsshvzccOiKEBsAa4mAomrrl7d0V5spx/q/I8VLOJ1P27R 3L9sseSY8oximJKpD4RWfAYz+W601Ze3KXZdJEhZaGGes5GKPHPSKoLPJ8AT5QSPrQ Yl3xnby4/i95etkw98sq04e4/xuKzxcyEaW9oD/fdsf+DfdXTqkoNpBkLdrj0eZ7By 25NefGNG4JCbw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wtKtg-0000000E0C5-3kju; Mon, 10 Aug 2026 07:58:12 +0000 Date: Mon, 10 Aug 2026 08:58:12 +0100 Message-ID: <86v79i9zl7.wl-maz@kernel.org> From: Marc Zyngier To: Karl Mehltretter Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually In-Reply-To: References: <20260803224405.41468-1-kmehltretter@gmail.com> <86mrv2arf2.wl-maz@kernel.org> <878q6fplpd.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kmehltretter@gmail.com, oupton@kernel.org, tabba@google.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 09 Aug 2026 19:11:54 +0100, Karl Mehltretter wrote: > > On Sun, Aug 09, 2026 at 12:39:10PM +0100, Marc Zyngier wrote: > > My current patch is as follows, and so far, I haven't seen much that I > > like better. > > > > Hi Marc, > > Thanks for your revised patch. > I think one correctness issue is in there. > > > + for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) > > + ret = init_nested_s2_mmu(kvm, &tmp[i]); > > > + if (ret) { > > + while (--i >= 0) > > + kvm_free_stage2_pgd(&tmp[i]); > > The increment expression of the for loop still runs after an error. Yup. Should be fixed with diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c index 5b69a0f382320..50d6dcc75582c 100644 --- a/arch/arm64/kvm/nested.c +++ b/arch/arm64/kvm/nested.c @@ -96,8 +96,11 @@ int kvm_vcpu_init_nested(struct kvm_vcpu *vcpu) if (!tmp) ret = -ENOMEM; - for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) + for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) { ret = init_nested_s2_mmu(kvm, &tmp[i]); + if (ret) + break; + } if (ret) { while (--i >= 0) M. -- Without deviation from the norm, progress is not possible.