From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227E4331A7E for ; Wed, 1 Jul 2026 14:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782916163; cv=none; b=JrIWk9jaPXyd6dtPeIc2zwnFoSC05F3IqzBp8++JElwoLXFjtiVs5assqk2XLOQTM5uKYYsep283r+W2kemnjg3jAR7YSyv0UzwBRkynACj1D56Bm8fhWEsLqwSMWBFlTP3x3ZRpKR/5dcG/a4Iv84lWK28tqU0Kp3Mh1350czs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782916163; c=relaxed/simple; bh=2nVsAox7TPd9R1vE6jXfr9AMPt6FPaq8FbS0a52KzMk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=WqjaWEERQ/9lWqmRVnq1s2H9TOo/Fj9Rm4xvXRl0zsY+vq0hynxiuFno/LzMHEtT+eUbWFWdB9S/k5s3EEurH+X9VArvxQSsoeWiDXP/JNINOFt4i/m4vByu8AUUYzQc7vq2xkUpC7VpEXFnr5ETrb3ONVRxwNmLnqkFDEZLWAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MTKAp6KD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MTKAp6KD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B44951F00A3A; Wed, 1 Jul 2026 14:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782916161; bh=W9jOzjqG5Rzz//GfX0/ecAtlcngTzgF0sG7TCjmqoyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MTKAp6KDEBhKMoaPtJO55E+C0RCxTAs+m6/7FjA8iAg8mDk29k/jdue8RDXN9mGdG adZ05+g9EFew11Gr1OQXKN+l6M4wMSe2/6WkhU78nwIPpzmd6TvT5urLlR5ka9dmDQ tjDfgC5ZWpqfoE1cQ6zhbcI+SooxCxIq7IHfxHqZ+fB2pwopY09CBTNoSQfolkIZ9a QL3VKqXUp636SWu4o1IDdO5x5tSzWk9mOT/CxaixNzLR2a9gbpWSLAm76KKh7S2kEG eBcp0ZON02Mwl7dHsDcl000YDW1BZ3ToXm4QUdjBVYjCZi6vxoSUmSwHtgwTpMTJpY OPw3DSppGeHgw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wevwF-00000000LyA-1YM0; Wed, 01 Jul 2026 14:29:19 +0000 Date: Wed, 01 Jul 2026 15:29:18 +0100 Message-ID: <86v7aypyv5.wl-maz@kernel.org> From: Marc Zyngier To: Jia He Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , Mark Brown , Sascha Bischoff , Fuad Tabba , Anshuman Khandual , Oliver Upton , linux-kernel@vger.kernel.org, Bin Guo Subject: Re: [PATCH] arm64/sysreg: Fix BWE field encoding in ID_AA64DFR2_EL1 In-Reply-To: <20260630222347.1449737-1-justin.he@arm.com> References: <20260630222347.1449737-1-justin.he@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: justin.he@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, lpieralisi@kernel.org, broonie@kernel.org, Sascha.Bischoff@arm.com, tabba@google.com, anshuman.khandual@arm.com, oupton@kernel.org, linux-kernel@vger.kernel.org, guobin@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 30 Jun 2026 23:23:47 +0100, Jia He wrote: > > Commit 93d7356e4b30 ("arm64: sysreg: Describe ID_AA64DFR2_EL1 fields") > encodes the FEAT_BWE2 value of the BWE field as '0b0002'. Binary > literals only accept the digits 0 and 1, so the intended value is 2, > i.e. 0b0010. > > The macro generated by gen-sysreg.awk currently expands to > #define ID_AA64DFR2_EL1_BWE_FEAT_BWE2 UL(0b0002) > is not legal C and would fail to compile if any in-tree code referenced > it. At present no caller uses this enum value, so the kernel still > builds cleanly, but the bug is latent. > > Fix the typo by using the correct binary literal 0b0010. > > Cc: Bin Guo > Fixes: 93d7356e4b30 ("arm64: sysreg: Describe ID_AA64DFR2_EL1 fields") > Signed-off-by: Jia He > Reviewed-by: Mark Brown > --- > arch/arm64/tools/sysreg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index bc1788b1662b..7cb61aca3797 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -1806,7 +1806,7 @@ Res0 15:8 > UnsignedEnum 7:4 BWE > 0b0000 NI > 0b0001 FEAT_BWE > - 0b0002 FEAT_BWE2 > + 0b0010 FEAT_BWE2 Well, that was embarrassing. FWIW (and given the original patch, that's not much): Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.