From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C847DC004C0 for ; Mon, 23 Oct 2023 13:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjJWNJU (ORCPT ); Mon, 23 Oct 2023 09:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjJWNJS (ORCPT ); Mon, 23 Oct 2023 09:09:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996A1C4; Mon, 23 Oct 2023 06:09:16 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C740C433C8; Mon, 23 Oct 2023 13:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698066556; bh=KqmsNij6B7/UeR8V5bqRN/2YnaXHLM0xwEH6flkSV18=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kNeVJnqRvx47FjHIY468IWlqGlvHLcQ+oAjN3PRib5r8LWQ41AFf2ozWQHPhB0bGy E38szNZL3hpzt1ygV3ucFurrW6eVDDguzDeDd5BMPWdYzNV/suqzfw7Y5XuQB2fpNh j3VnXBvrBvpNLbmgkSKE3NxUDtZhoe0IavH7xcgTNiIf7NnETxVB56IqjJa/IV/u8H xIqza/70sJ0aeos+w3M7G+9HC/yKxQjGeOerM3yH+oYrHRNNBZqqyKB0uhOrQiScTd 1kjfaN+DH1GLgIRtv0s6Y8kImMoj9FAr9ypX8BECzFYBjyCL2xnNPzkudteE6M/uJm a7w8C8f1K39mQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quugD-006qbg-UQ; Mon, 23 Oct 2023 14:09:14 +0100 Date: Mon, 23 Oct 2023 14:09:13 +0100 Message-ID: <86v8ax4hae.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU In-Reply-To: <20231020214053.2144305-1-rananta@google.com> References: <20231020214053.2144305-1-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Oct 2023 22:40:40 +0100, Raghavendra Rao Ananta wrote: > > Hello, > > The goal of this series is to allow userspace to limit the number > of PMU event counters on the vCPU. We need this to support migration > across systems that implement different numbers of counters. [...] I've gone through the initial patches, and stopped before the tests (which I usually can't be bothered to review anyway). The comments I have a relatively minor and could be applied as fixes on top if Oliver can be convinced to do so. Note that patch #4 has an attribution issue. > base-commit: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 maz@valley-girl:~/hot-poop/arm-platforms$ git describe 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 fatal: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 is neither a commit nor blob Can you please make an effort to base your postings on a known, stable commit? A tagged -rc would be best. but certainly not a random commit. This sort of information is just as useful as "No functional change intended"... M. -- Without deviation from the norm, progress is not possible.