From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE1CCE79AD for ; Wed, 20 Sep 2023 09:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234163AbjITJvj (ORCPT ); Wed, 20 Sep 2023 05:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231948AbjITJvg (ORCPT ); Wed, 20 Sep 2023 05:51:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A759A3 for ; Wed, 20 Sep 2023 02:51:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D66F1C433C7; Wed, 20 Sep 2023 09:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695203490; bh=N8ZLggmYMnn+YtdULCemgfJEc5yqhwLremHJS2MrLg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R0H7fWFpFPy4USe9OY7GEwDP46a3AGPyGCGSLufeH76Gktirywu0ARTx74+5OZgJ7 Acz3W85Ivgul8ASndW8Jg0LMYGRWLWdIphk18rJvit9h3fVQbiWxukJToiO2g1WMzP BLwniNCuhIP7rJ27kNnb0+XdNS2ACneaKKmyXL1Tt1jexgKcB7TX7RQvwto9kpKHM5 Rf4H1+IG7uNVviIgZ+/CQ2hGIbQsc973rPQgzwKtQVhg7jiL0YdxSpjMdbYFZ64LPt iuWhW0fDV169qAg9VvHxrFwnsgXtgAPHvBJCOoAQ13odv0fl6EaI9F4ddEESLFe0jR L2hl+2a46vuUg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qitrk-00EaUm-GG; Wed, 20 Sep 2023 10:51:28 +0100 Date: Wed, 20 Sep 2023 10:51:27 +0100 Message-ID: <86v8c5cgv4.wl-maz@kernel.org> From: Marc Zyngier To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Chris Zankel , Max Filippov , Thomas Gleixner Subject: Re: [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype In-Reply-To: <20230920052139.10570-10-rdunlap@infradead.org> References: <20230920052139.10570-1-rdunlap@infradead.org> <20230920052139.10570-10-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rdunlap@infradead.org, linux-kernel@vger.kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Sep 2023 06:21:32 +0100, Randy Dunlap wrote: > > Add to provide the function prototype to > prevent a build warning: > > drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes] > 166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent) > > Signed-off-by: Randy Dunlap > Cc: Chris Zankel > Cc: Max Filippov > Cc: Thomas Gleixner > Cc: Marc Zyngier > --- > drivers/irqchip/irq-xtensa-mx.c | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c > --- a/drivers/irqchip/irq-xtensa-mx.c > +++ b/drivers/irqchip/irq-xtensa-mx.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > > #include > Acked-by: Marc Zyngier It also begs the question of the continuing support for non-DT driven systems. Max, Chris: are we any closer to being DT-only on the xtensa front? Thanks, M. -- Without deviation from the norm, progress is not possible.