From: Marc Zyngier <marc.zyngier@arm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tglx@linutronix.de, jason@lakedaemon.net, vz@mleia.com,
slemieux.tyco@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf
Date: Fri, 22 Sep 2017 09:10:41 +0100 [thread overview]
Message-ID: <86vakbnofy.fsf@arm.com> (raw)
In-Reply-To: <1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Wed, 20 Sep 2017 13:38:18 +0530")
On Wed, Sep 20 2017 at 1:38:18 pm BST, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> kasprintf() can fail here and we must check its return value.
Or not. The use of these strings is purely cosmetic (they are only used
to display various debug information), and printk is perfectly able to
handle a NULL string.
Refusing to probe an essential piece of HW because a debug feature
failed seems at best counter-productive.
Thanks,
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2017-09-22 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:08 [PATCH 0/4] iirqchip: Handle return value of kasprintf Arvind Yadav
2017-09-20 8:08 ` [PATCH 1/4] irqchip/gic-v3-its: " Arvind Yadav
2017-09-20 8:08 ` [PATCH 2/4] irqchip/gic-v3-its-platform-msi: " Arvind Yadav
2017-09-20 8:08 ` [PATCH 3/4] irqchip/gic: " Arvind Yadav
2017-09-22 8:10 ` Marc Zyngier [this message]
2017-09-22 8:57 ` [PATCH 0/4] iirqchip: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86vakbnofy.fsf@arm.com \
--to=marc.zyngier@arm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox