public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
	 Mike Rapoport <rppt@kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency
Date: Thu, 04 Dec 2025 11:12:02 +0100	[thread overview]
Message-ID: <86wm32lfnx.fsf@kernel.org> (raw)
In-Reply-To: <20251204100203.1034394-1-arnd@kernel.org> (Arnd Bergmann's message of "Thu, 4 Dec 2025 11:01:58 +0100")

On Thu, Dec 04 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The new memfd code fails to link without SHMEM:
>
> aarch64-linux-ld: mm/memfd_luo.o: in function `memfd_luo_retrieve_folios':
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0xdc): undefined reference to `shmem_add_to_page_cache'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x11c): undefined reference to `shmem_inode_acct_blocks'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x134): undefined reference to `shmem_recalc_inode'
>
> Add a Kconfig dependency to disallow that configuration.
>
> Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks!

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

> ---
>  kernel/liveupdate/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
> index 86a58eaf433a..80b77db2b0e0 100644
> --- a/kernel/liveupdate/Kconfig
> +++ b/kernel/liveupdate/Kconfig
> @@ -53,6 +53,7 @@ config KEXEC_HANDOVER_ENABLE_DEFAULT
>  config LIVEUPDATE
>  	bool "Live Update Orchestrator"
>  	depends on KEXEC_HANDOVER
> +	depends on SHMEM
>  	help
>  	  Enable the Live Update Orchestrator. Live Update is a mechanism,
>  	  typically based on kexec, that allows the kernel to be updated

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2025-12-04 10:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 10:01 [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency Arnd Bergmann
2025-12-04 10:12 ` Pratyush Yadav [this message]
2025-12-04 11:01 ` Mike Rapoport
2025-12-04 14:09 ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wm32lfnx.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox