From: Keith Packard <keithp@keithp.com>
To: Dave Airlie <airlied@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3]
Date: Wed, 05 Jul 2017 20:38:40 -0700 [thread overview]
Message-ID: <86wp7mtetb.fsf@keithp.com> (raw)
In-Reply-To: <CAPM=9tzVpuXZW1B8cO14wdAwAniHGnKfTkJH7rLHEERz6cLO=Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
Dave Airlie <airlied@gmail.com> writes:
> I think this needs a pad ^.
> And this.
Yup. Thanks!
>> +struct drm_mode_revoke_lease {
>> + /** Unique ID of lessee
>> + */
>> + __u32 lessee_id;
>
> And this.
None of the other bare 32-bit ioctl structures are padded; I think
that's probably fine as they'll be 4 bytes on both 64-bit and 32-bit
machines.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-07-06 3:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 22:24 [PATCH 0/6] drm: Add mode object leases [v3] Keith Packard
2017-07-05 22:24 ` [PATCH 1/6] drm: Pass struct drm_file * to __drm_mode_object_find Keith Packard
2017-07-05 22:24 ` [PATCH 2/6] drm: Allow render nodes to query display objects Keith Packard
2017-07-05 22:24 ` [PATCH 3/6] drm: Add new LEASE debug level Keith Packard
2017-07-05 22:24 ` [PATCH 4/6] drm: Add drm_object lease infrastructure [v3] Keith Packard
2017-10-05 3:55 ` Dave Airlie
2017-07-05 22:24 ` [PATCH 5/6] drm: Check mode object lease status in all master ioctl paths [v2] Keith Packard
2017-07-05 22:24 ` [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3] Keith Packard
2017-07-06 0:42 ` Dave Airlie
2017-07-06 3:38 ` Keith Packard [this message]
2017-10-05 3:17 ` Dave Airlie
2017-10-05 3:24 ` Dave Airlie
2017-10-05 3:37 ` Dave Airlie
2017-10-05 6:23 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wp7mtetb.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).