From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04EC93446C0; Mon, 9 Feb 2026 09:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770628931; cv=none; b=QjITMrqEs4LTrP/NHShdbi4XQGKBb7q9PADDOtUUdv43RssMj4UobfwvX1Ulufc8xyLQZMOG7ddfpZi3bxjuP8lf1XV75JGohzYqYtraNmHY2FnQaBvhsQv6ugk/pKO6NgArLI1VwR0KwInmnsvCJ+ehMzBe/dhOI5eE8Hkqs0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770628931; c=relaxed/simple; bh=cIMc0AWi7lb3E7b2oWk6KZ1wEX8lLo1DYxXZtE8SEWM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=D/NxeFj0NaM5y3dtnx4ckf4PGJ4iCkgSAfTpjevbG+BVh/DBJE5yJI3wKeCXFeYVgf8cOMjqVg9hG6cBLZ4s0v/ytiTBeCaGmMOiUstvJcKzip7B53+0wXlA4A0Z7krHaXchKgNeqCJQUjGOxCPm9b/K6ZUDNzKhEbf6kDR5I/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lEVMy3Ep; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lEVMy3Ep" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 869EFC116C6; Mon, 9 Feb 2026 09:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770628930; bh=cIMc0AWi7lb3E7b2oWk6KZ1wEX8lLo1DYxXZtE8SEWM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lEVMy3Ep0br3N10YgShH2kguLeOfcPEKWyKjDkqj3lqK/INzRqSHTQiwXxjUwKaC0 L71ZhKSZkxfxEG8LpnMij7geLIUI8Y+N+x1tKVX1sV0CHaaTfNqwTS6K4Dzif/LKN2 Wvnp/RAxk2SSzwbZsgBElYArn1CrdHCg5iGRaFYgJo8rBryku4if7RfbBGaCgYp44c fcj+zO1fYwACYlsKNaSDv1vNIceUtCBXK4PyOirQZYOpL3VHjymruX8sPTCPjQjppj gzr+Q9BtY0upm32qrE0rXjt199e6GSigjD/IGmHPMZ/KnY1vvBSZd9otJ2I74aC/0n a3RV7wBGzTsDQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vpNT6-00000009iFb-0PfL; Mon, 09 Feb 2026 09:22:08 +0000 Date: Mon, 09 Feb 2026 09:22:07 +0000 Message-ID: <86y0l2b7b4.wl-maz@kernel.org> From: Marc Zyngier To: Cc: Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Matthias Brugger , AngeloGioacchino Del Regno , Quentin Perret , Vincent Donnefort , , , , , , , Subject: Re: [PATCH] KVM: arm64: Allow module-owned pages in host stage-2 range adjustment In-Reply-To: <20260209032421.1278325-1-kyle-jk.liao@mediatek.com> References: <20260209032421.1278325-1-kyle-jk.liao@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kyle-jk.liao@mediatek.com, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, qperret@google.com, vdonnefort@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, rock.yeh@mediatek.com, hungwen.chien@mediatek.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 09 Feb 2026 03:24:13 +0000, wrote: > > From: "kyle-jk.liao" > > The host_stage2_adjust_range() function triggers a WARN_ON when > encountering pages marked as both PKVM_NOPAGE and PKVM_MODULE_OWNED_PAGE. > This occurs when load_unaligned_zeropad() accesses memory that crosses > page boundaries, where one of the pages is module-owned. > > Extend the check to accept pages with the PKVM_MODULE_OWNED_PAGE flag > in addition to PKVM_NOPAGE, preventing spurious warnings during normal > module memory access patterns. > > Signed-off-by: kyle-jk.liao > --- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index 49db32f3ddf7..baaabf4b5112 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -495,6 +495,7 @@ static int host_stage2_adjust_range(u64 addr, struct kvm_mem_range *range) > u64 granule; > s8 level; > int ret; > + enum pkvm_page_state state; > > hyp_assert_lock_held(&host_mmu.lock); > ret = kvm_pgtable_get_leaf(&host_mmu.pgt, addr, &pte, &level); > @@ -505,8 +506,9 @@ static int host_stage2_adjust_range(u64 addr, struct kvm_mem_range *range) > return -EAGAIN; > > if (pte) { > + state = get_host_state(hyp_phys_to_page(addr)); > WARN_ON(addr_is_memory(addr) && > - get_host_state(hyp_phys_to_page(addr)) != PKVM_NOPAGE); > + (state != PKVM_NOPAGE && state != (PKVM_NOPAGE | PKVM_MODULE_OWNED_PAGE))); > return -EPERM; > } > None of that exists upstream. M. -- Without deviation from the norm, progress is not possible.