From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F91D22E3FF; Thu, 16 Jan 2025 18:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737051911; cv=none; b=Qqz6kaG6OAFoBMFs4AP+Pv9q2nnv7Tj3p4AUGbn+4A2wly9Ql5caLqnuA3QwFYaMpPRLZuSXUrLDWBAFT4mqPihdPBQ/4f/rneiwK5osXy776Kra+pWbiqTD5iDycO9bIQNi0j6emLNgDLB9Sr7D9/kJfXBnegIsjjAgCiHdtYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737051911; c=relaxed/simple; bh=EU6PpibWHJM3Ka80rEEuKYaqyZV32Fze3gQ66ir92js=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=iBz6G1BHROECOGC9p+EUMYD0OvgJtn9wJIYuZR/QdCkAsghN3s23W6CAVm1/IkXD6mlWEewv1t5qg/RgxXkpJiskBRzRJklYZYtaiIzZDa+qLumRGv3i0JWMfoOR/EVAvuIF8aY3wTUZOoO41/IwLdh4d59rO3JEpyB7+cToAQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ROeKW+OP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ROeKW+OP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BE3DC4CED6; Thu, 16 Jan 2025 18:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737051910; bh=EU6PpibWHJM3Ka80rEEuKYaqyZV32Fze3gQ66ir92js=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ROeKW+OP4EH5DkODSpECUPpm8Svwv/fb32oDFq0mI2VBnKLZPkQ8nnBLW6znVJQ3o lIadpEdHBBXVGeHuvpO8FZ55/SrGpAe+qk6BWWJbf1PfwA/reaxZlC+7daqb1qyYUt 5Tx/apO4rclvAG06WImqKoRaBXdCDwzxWn2Bkvni7E/n5xvdCXK311poaaEnY5U6/w dK9cyIEjWf/LQd0kWbAsF+his8CYxaexOPlIMvQ+m9QIo7+OoHFXhkqWeolzj8m8iE 0rsPj4/wwox2adU1BGUTvKgTwNKxW6947Dvt9MVZecnHxlFLJOCa8Svjqpk6dis/f6 FXeqI4slrj7IQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tYUYG-00Ct9M-CZ; Thu, 16 Jan 2025 18:25:08 +0000 Date: Thu, 16 Jan 2025 18:25:07 +0000 Message-ID: <86y0zavcos.wl-maz@kernel.org> From: Marc Zyngier To: Eric Auger Cc: Ganapatrao Kulkarni , kvmarm , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, christoffer.dall@arm.com, suzuki.poulose@arm.com, will@kernel.org, catalin.marinas@arm.com, coltonlewis@google.com, joey.gouly@arm.com, yuzenghui@huawei.com, darren@os.amperecomputing.com, vishnu@os.amperecomputing.com Subject: Re: [PATCH] KVM: arm64: nv: Set ISTATUS for emulated timers, If timer expired In-Reply-To: References: <20241209053201.339939-1-gankulkarni@os.amperecomputing.com> <867c89tc4q.wl-maz@kernel.org> <865xntt2kv.wl-maz@kernel.org> <8be59ff3-6a68-48e1-8181-0ce4b2e7180f@os.amperecomputing.com> <86y10osr19.wl-maz@kernel.org> <4d443db1-85b1-4071-acd5-3187deb9cb17@redhat.com> <2f6b2cb1-3d32-480a-9801-9b993ae74e2d@os.amperecomputing.com> <152d262e-641d-4bb1-9656-a13e049d62c4@redhat.com> <86h661wje4.wl-maz@kernel.org> <4a9fbdd9-ad23-44bc-8ba5-399f08068db4@redhat.com> <86cygpwfy0.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: eauger@redhat.com, gankulkarni@os.amperecomputing.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, christoffer.dall@arm.com, suzuki.poulose@arm.com, will@kernel.org, catalin.marinas@arm.com, coltonlewis@google.com, joey.gouly@arm.com, yuzenghui@huawei.com, darren@os.amperecomputing.com, vishnu@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Hi Eric, On Thu, 16 Jan 2025 17:52:10 +0000, Eric Auger wrote: > > >>>> I tested on AmpereOne and Grace-Hopper systems > >>> > >>> Thanks for the confirmation. I haven't had a chance to try QEMU yet, > >>> but I expect that save/restore will not work. Something to look into, > >> I have not tested this yet.I will give it a try. > > > > Thanks, that'd be super helpful. > > I confirm the migration fails when putting some registers on the dest > side. I will further investigate. Thanks for confirming. I suspect that the kernel visibility bits are not exactly correct (or depend on some odd ordering). If you can point me to a register that fails to restore correctly, that'd be useful. Hopefully, most EL2-specific registers suffer from the same defect. Cheers, M. -- Without deviation from the norm, progress is not possible.