From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B093E1BD9F8; Wed, 30 Oct 2024 17:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730307755; cv=none; b=RMD5CGb/kbKZ78/A7+p7mgNi1gsXX8WeNrSlFZNvK0SMbiBzvtJl8St3VEjN1MkwdDm6CY/UsnOJJxKipe38SQZ7p5xzcbZaf1FAUYn6LFXB7KDXdjoYS7HXsAy18DoBKHuTNQaafAP41jDftYDdLKP5ru4v6PL0mhPkpg+5n/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730307755; c=relaxed/simple; bh=jN7ufuRsDHj2hnXvEktu0zRiCMTOU1pCOkwbJZt1a4E=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=q69Iq9IjFGB4H7n8YW+eijfunw36dcQ+11HgXgsw4S4YPnEP9erT/An9akitc4aYEbiCU3/M0L9zy2WpzZThZYoPSIHR1JesrTRVQPQORQKXR+Ay+eMdDzVicZlCon6DNZnO/zSblGHX2zi7+7nkcP4ou6DH2muA5MXLhOP2guM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RpQXzE6G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RpQXzE6G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24AECC4CECE; Wed, 30 Oct 2024 17:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730307755; bh=jN7ufuRsDHj2hnXvEktu0zRiCMTOU1pCOkwbJZt1a4E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RpQXzE6GodATaou2ro8yzFVZ4GZkKOqncf8OdXmZ9KD3G133jUnkzKZmfgyO4orSt 7464y1xKHL5lasMexQBEPtwqSwVVDUqhKPPG8mc3CQZ6/st3TRsyXeHTiKSCRfRgro rEKH/YOWSNcvfZMcZXH5mIl6gFO9TkOWd8bBERAhz5ACD22+aWwUiAduUeuF0LF87F 5+D/BJ4O69rWZkeiavHod4xrZW/R9wZJYNf0IkCsKpoQo6cwT3Z9g3uXEMcDfQdbFj as2YAMqV3KQmBO5CmxXB2gvBxgcjPeou5Q2FTMAWyiw0SUPJPvymeE6PxI6zEVYLnD ucPw6fv2qRGtQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t6C5Y-008Kmh-TJ; Wed, 30 Oct 2024 17:02:33 +0000 Date: Wed, 30 Oct 2024 17:02:32 +0000 Message-ID: <86y1251q3b.wl-maz@kernel.org> From: Marc Zyngier To: Sibi Sankar Cc: , , , , , , , , , , , , Subject: Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows In-Reply-To: <20241025123227.3527720-1-quic_sibis@quicinc.com> References: <20241025123227.3527720-1-quic_sibis@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: quic_sibis@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, abel.vesa@linaro.org, srinivas.kandagatla@linaro.org, quic_jjohnson@quicinc.com, jens.glathe@oldschoolsolutions.biz X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 25 Oct 2024 13:32:24 +0100, Sibi Sankar wrote: > > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. My machine has the following information as part of its DMI tables: Handle 0x0005, DMI type 1, 27 bytes System Information Manufacturer: Qualcomm Product Name: Snapdragon-Devkit Version: 2.1 Serial Number: 5 UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 Wake-up Type: Power Switch SKU Number: 6 Family: SCP_HAMOA So I guess that Snapdragon-Devkit is another possible name. But given that it is a bit of a mouthful, devkit, Devkit, or any other variation on the case would work for me. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts FWIW, I'm running this as part of my KVM test rig with minor changes to expose the SMMU and allow the ITS on pcie5, and things work as well as you can expect. FWIW: Acked-by: Marc Zyngier Tested-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.