From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFD1C433FE for ; Thu, 17 Nov 2022 19:37:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234894AbiKQThI (ORCPT ); Thu, 17 Nov 2022 14:37:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233225AbiKQThE (ORCPT ); Thu, 17 Nov 2022 14:37:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A16887570 for ; Thu, 17 Nov 2022 11:37:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2905FB82101 for ; Thu, 17 Nov 2022 19:37:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3078C433C1; Thu, 17 Nov 2022 19:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668713820; bh=YCFOtk7JBzhIwUsv4FanZcQX+MYSaTlook2QWHvkNa4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jCKgellvHA8N2E2PGeI3BG0qtk6wUz5JkaSbIK9ZtXDR4rRcdzjUJGICxTD6ph7PW Gq01NGyvIEd2CfqlDG21VbU7v/3f0q+4KPEVsYUUgjCtfyw0fzYKmknL0WD5cYk1Py 71wIn2Dp/4Y9B9RgLcR9qv2abT/2c7axs1XTPPe5vgNAFFgdr5sDDLzKIUkeTce2cN udMqvzekf6imAXhEXgPJx2pBrKRoolbRF5wjcEim7e4SIQ0RsYvHJxkX2zNSRb4UtY uD7rlCsr+5Flb2WXP/nvwZglm2BvOmI9IUjy0WYDKjggiYxNRztQl1xDLBX+ReIk1L uTpxg88mw3PoQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovkh0-006opa-9Q; Thu, 17 Nov 2022 19:36:58 +0000 Date: Thu, 17 Nov 2022 19:36:57 +0000 Message-ID: <86y1s9nzja.wl-maz@kernel.org> From: Marc Zyngier To: Conor Dooley Cc: Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Conor Dooley Subject: Re: [PATCH] irqchip/sifive-plic: default to enabled In-Reply-To: <20221117185942.3896559-1-conor@kernel.org> References: <20221117185942.3896559-1-conor@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: conor@kernel.org, tglx@linutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, conor.dooley@microchip.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Nov 2022 18:59:43 +0000, Conor Dooley wrote: > > From: Conor Dooley > > The SiFive PLIC driver is used by all current implementations, including > those that do not have a SiFive PLIC. Default the driver to enabled, > with the intention of later removing the current "every SOC selects > this" situation in Kconfig.socs at the moment. > > The speculative "potential others" in the description no longer makes > any sense, as the driver is always used. Update the Kconfig symbol's > description to reflect the driver's ubiquitous state. > > Signed-off-by: Conor Dooley > --- > Hey Marc, > > I recall some discussion when this driver was extended to other PLICs a > few months ago: > https://lore.kernel.org/linux-riscv/20511a05f39408c8ffbcc98923c4abd2@kernel.org/ > > Perhaps I got the wrong impression, but it seemed to me that you intend > for future implementations to reuse this driver where possible? Well, within reasons. People seem to have some very liberal interpretations of the architecture spec... > > I'd like to think, and surely will be proven wrong, that ~all future > plic implementations should be similar enough to fit that bill. > It's kinda on this basis that I figure switching this thing to default y > should be okay. It's already only buildable on RISC-V & every > implementation uses it, so no difference there. If you expect this to be present at all times, why isn't this selected by the architecture Kconfig instead? I always find it pretty odd to have something that is 'default y' and yet constrained by a 'depend MYARCH'. A 'select PLIC' would make a lot more sense. And then you can stop making this user selectable. Thanks, M. -- Without deviation from the norm, progress is not possible.