From: Keith Packard <keithp@keithp.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
Michal Marek <mmarek@suse.com>,
"intel-gfx\@lists.freedesktop..."
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Mon, 09 Jan 2012 09:22:47 -0800 [thread overview]
Message-ID: <86y5tgx02g.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20120109131717.GA4713@localhost>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:
> +#define IBX_AUD_CONFIG_A 0xe2000
> +#define CPT_AUD_CONFIG_A 0xe5000
These register addresses match the docs.
> + I915_WRITE(aud_config, 1 << 29); /* N value index, 0x1 = DP */
Please don't use constants here, instead add #defines for all of the
bits in this new register, in case someone else needs to use the
register later.
Do we also need to program the pixel clock values in this register?
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2012-01-09 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 13:17 [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort Wu Fengguang
2012-01-09 17:22 ` Keith Packard [this message]
2012-01-10 5:45 ` Wu Fengguang
2012-01-12 17:33 ` Keith Packard
2012-01-16 8:02 ` Wu Fengguang
2012-01-16 20:26 ` [Intel-gfx] " Daniel Vetter
2012-01-16 20:44 ` Keith Packard
2012-01-16 23:08 ` Wu Fengguang
2012-01-16 23:15 ` Keith Packard
2012-01-17 10:22 ` Daniel Vetter
2012-01-29 4:44 ` [PATCH][rebased] " Wu Fengguang
2012-01-29 12:12 ` Daniel Vetter
2012-01-29 13:23 ` Wu Fengguang
2012-01-29 15:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y5tgx02g.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=fengguang.wu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).