From: Marc Zyngier <maz@kernel.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Conor Dooley <conor@kernel.org>,
apatel@ventanamicro.com, oliver.sang@intel.com,
Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org,
lkp@lists.01.org, lkp@intel.com
Subject: Re: [mm] 408579cd62: WARNING:suspicious_RCU_usage
Date: Mon, 03 Jul 2023 19:33:21 +0100 [thread overview]
Message-ID: <86zg4cx2tq.wl-maz@kernel.org> (raw)
In-Reply-To: <mhng-ce7af44f-732e-4a48-adb4-62deb17b3eb9@palmer-ri-x1c9>
On Mon, 03 Jul 2023 19:11:27 +0100,
Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> On Mon, 03 Jul 2023 10:46:55 PDT (-0700), Linus Torvalds wrote:
> > On Mon, 3 Jul 2023 at 10:34, Marc Zyngier <maz@kernel.org> wrote:
> >>
> >> Comparing with what we do on arm64, a less radical change would be to
> >> move the IPI init after notify_cpu_starting(), which explicitly
> >> enables RCU usage.
> >
> > Ack, that looks right to me.
>
> I don't see anything wrong with it and it's passing my tests, but
> we've got a handful of ways to boot so it's all a bit messy and I
> might be messing something.
>
> I'm still catching up a bit as I took both days off this weekend.
> Hopefully just an oversight in a bigger rafactoring, but I'll give it
> another look.
>
> Marc: are you going to send that as a patch?
Just did [1].
Thanks,
M.
[1] https://lore.kernel.org/r/20230703183126.1567625-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-07-03 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 2:04 [mm] 408579cd62: WARNING:suspicious_RCU_usage kernel test robot
2023-07-03 4:34 ` Linus Torvalds
2023-07-03 17:00 ` Conor Dooley
2023-07-03 17:07 ` Linus Torvalds
2023-07-03 17:20 ` Conor Dooley
2023-07-03 17:34 ` Marc Zyngier
2023-07-03 17:46 ` Linus Torvalds
2023-07-03 18:11 ` Palmer Dabbelt
2023-07-03 18:33 ` Marc Zyngier [this message]
2023-07-04 1:46 ` Oliver Sang
2023-07-04 2:29 ` Linus Torvalds
2023-07-04 13:51 ` Oliver Sang
2023-07-04 15:25 ` Liam R. Howlett
2023-07-04 18:04 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zg4cx2tq.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=apatel@ventanamicro.com \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
--cc=palmer@rivosinc.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox