From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C6E18A6AE; Wed, 9 Jul 2025 05:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752038816; cv=none; b=PrnzcLuQaVGKbfXyWwKaarlOKDSD9XjMKzQq5F750HFuqKN8g84Ti6FOr6KqTjbSptE+PP094zc6bOXyhTkXEftnGTdFrqA8xFnVppFGnpTjcQwoWSHiNltuVD2xf6IOL2c3QYknXdWE8zl6nM6EJ5Fme8BcI59j+Qxr1g9xdRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752038816; c=relaxed/simple; bh=J3zTTmCJxvUBuBboEAuu182Tn48ni4t7yWkd9I7MydM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L9K8VMIorwmsIt5MgTKATXXfcplXWSPCb3D4GX9L+Q8jnkZTSyIOEtZnfSqiJjw17yFt3lMlwz/L6oSRYYJ9KYCfwM323yTpP36QmXzS+0pr+n8fu73WOEgcjlbqQAswq+Z/+bMEoo62bf128LgV5cXGb7UZa78zOiCyRb88g4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Ru37LWJ6; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ru37LWJ6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=JEnnyFaI59W4HNdgSd7HYPu9jFz+8K/pGInaewzc67Y=; b=Ru37LWJ6vsD/V/WrcrSQDLICEE wQGb5JRwdBFhM0W9QsHQVza6wLt2ViP4ykDdhkb8XYtGijVD85CRgSayLfaQtHNfL/SVEufmOlJat 7R9FPkl986PP0UXCk73gyo30OerlWcy2+lxLf9MLt8rE/hWtjnYM5vjVm4MVep7DDfbhYyyYeClhF JtwRbu6Dkp7L4yv5Y7NHIRMgPoFky28XEXTxV8vJjqEQilXMNtynhnE31F6/4O5U+1YCOfiWWzVrX +vpUTh1qvITQWC5+iTWjTODQaW2dNVTm7Gcw48SIKBrsURt9pQQDLclm+KYEChWkpp/w3YUvEKRtn +cVIb/uA==; Received: from [50.53.25.54] (helo=[192.168.254.17]) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZNKQ-00000002bK2-30bC; Wed, 09 Jul 2025 05:26:46 +0000 Message-ID: <87031b13-88c7-44c3-bb4d-adbae2b92d13@infradead.org> Date: Tue, 8 Jul 2025 22:26:41 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected usage in literal code block To: Bagas Sanjaya , Linux Kernel Mailing List , Linux Documentation , Linux DRI Development Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Danilo Krummrich , Rob Clark , Antonino Maniscalco , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Raag Jadav , Stephen Rothwell References: <20250709024501.9105-1-bagasdotme@gmail.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20250709024501.9105-1-bagasdotme@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/8/25 7:45 PM, Bagas Sanjaya wrote: > Stephen Rothwell reports multiple indentation warnings when merging > drm-msm tree: > > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2445: ERROR: Unexpected indentation. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2447: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2451: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2452: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2456: ERROR: Unexpected indentation. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2457: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2458: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] > Documentation/gpu/drm-mm:506: ./drivers/gpu/drm/drm_gpuvm.c:2459: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] > > Fix these by wrapping drm_gpuvm_sm_map_exec_lock() expected usage > example in literal code block. > > Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers") > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/linux-next/20250708192038.6b0fd31d@canb.auug.org.au/ > Signed-off-by: Bagas Sanjaya > --- > drivers/gpu/drm/drm_gpuvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c > index bbc7fecb6f4ab4..f62005ff9b2eef 100644 > --- a/drivers/gpu/drm/drm_gpuvm.c > +++ b/drivers/gpu/drm/drm_gpuvm.c > @@ -2430,7 +2430,7 @@ static const struct drm_gpuvm_ops lock_ops = { > * remapped, and locks+prepares (drm_exec_prepare_object()) objects that > * will be newly mapped. > * > - * The expected usage is: > + * The expected usage is:: > * > * vm_bind { > * struct drm_exec exec; > > base-commit: 8290d37ad2b087bbcfe65fa5bcaf260e184b250a Acked-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. -- ~Randy