From: David Woodhouse <dwmw2@infradead.org>
To: "Kristofer T. Karas" <ktk@bigfoot.com>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>,
"Kristofer T. Karas" <ktk@enterprise.bidmc.harvard.edu>,
linux-kernel@vger.kernel.org,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [Patch - 2.4.17++] Fix undefined ksym in minix.o, ext2.o, sysv.o
Date: Tue, 22 Jan 2002 23:58:53 +0000 [thread overview]
Message-ID: <8704.1011743933@redhat.com> (raw)
In-Reply-To: <200201222237.g0MMb7a17456@enterprise.bidmc.harvard.edu>
In-Reply-To: <200201222237.g0MMb7a17456@enterprise.bidmc.harvard.edu> <200201222216.g0MMGj317058@enterprise.bidmc.harvard.edu> <3C4DE863.6E486FA5@mandrakesoft.com>
ktk@bigfoot.com said:
> Fair enough. A "grep -r" showed it existing only in ./fs/ and only
> ref'd by ext2, sysv and minix; so I figured a conditional wrap-around
> wouldn't hurt. But I didn't stop to consider 3rd party modules...
It's not just third-party modules. Even the modules in the tree get bitten
by such brokenness - consider what happens if you compile your kernel
without support for the filesystem in question but later need to compile
the module. With the #ifdef there, you'd need to recompile (and reboot) the
whole thing.
Anything in the kernel image which is dependent on CONFIG_*_MODULE is, as a
general rule, broken. Sometimes there are justifications for it. Not often,
though.
--
dwmw2
prev parent reply other threads:[~2002-01-22 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-22 22:16 [Patch - 2.4.17++] Fix undefined ksym in minix.o, ext2.o, sysv.o Kristofer T. Karas
2002-01-22 22:32 ` Jeff Garzik
2002-01-22 22:37 ` Kristofer T. Karas
2002-01-22 23:58 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8704.1011743933@redhat.com \
--to=dwmw2@infradead.org \
--cc=jgarzik@mandrakesoft.com \
--cc=ktk@bigfoot.com \
--cc=ktk@enterprise.bidmc.harvard.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox