From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbcFVOAW (ORCPT ); Wed, 22 Jun 2016 10:00:22 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:58045 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbcFVOAR (ORCPT ); Wed, 22 Jun 2016 10:00:17 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: Deepa Dinamani , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, viro@zeniv.linux.org.uk, Jan Kara , tglx@linutronix.de, torvalds@linux-foundation.org Subject: Re: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time() Date: Wed, 22 Jun 2016 15:54:26 +0200 Message-ID: <8704234.tYHdNQJqxT@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466382443-11063-10-git-send-email-deepa.kernel@gmail.com> References: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> <1466382443-11063-10-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jQ4kum9Jz9QLEcPqbxEYiDSHv9xj21TjVuqi22PYaelXakiP3Ot zKfmcCt0DWQEjdIWnfm16SLpzhDTGIkhOBqMwn4APX0Thk9bA0LI0Vq6M9G64DPNfA2o1k/ GgGYjukJ15ipUheelJdI0DOEJNaxQdOE0DlfaVOQZJhD5AcViW6qDlEctOF1eo06U8LJbMF juoZrK3lZNa4p2aafsTZA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Bi+Y7oYBzFI=:MMteTNm6dpXq2guPhWKjgn oWrY5az4C35WC6bcRojUlW9iZwjR4mi49FdPeg1KrxqA3MAHixElihVOIn7F7uDkjcKm/b40P eMQVPPOXeXK8MrPsMRMeFEAD6j+KHWXtcG0Su1aN/RpBfISBTGk+Jjr0sYuY+V0IPXhgciIOp HCXBMAs+CmH+5iGguth2c1ueuQP3CU2FY2Ye/gYG+z5vxAkdViZSxZM8GxcCuxF0kImyEzRZ3 4A/fFnATTdLJO4Ym9BQRc4kl1Z31nJGc/3tlXqGemQt88vtUjnnEsf/C6CXQ/b1cS8AAxMDXr vkXwJaGpBI9TOmXctDTpSCQwtRTgcRoc3diQhrq9IFA/BHWyIb/SVxZ5OcU9svPNSchcyqtO4 9cEdERhjw/C7405KZZ64S7E4Fv0Ug/RunXOng3h8rCDgR/PIQOBlD1JU4sMTTQqaMYMW83uyP VG2dS10LYHw6EPnOWlK83fMZveQdceNOBPcj5hKtCAbR1CXD2PvhZpuwY/qQo1PmxiM9gOStx 4I1y6m/6O3hmJ0sYw65SB4n2WooR7VNgcJ5XCKzsMwSvzpoJy5RJbVcWPZ5ur+xeDlhA+gYVB uOECkAwy8q+uLCtUsFUL71HZm06wafIrg/8OiwpPBrYZ0w8ZOk3IV2QC+ke7h5x7NH/BwVXvi DVIeTJae/53Kp4cXmnEAjiUNNOvOVw+So9RhSTO5+1/RJzgLRtmFdcCbaphXnJwcVoVXH+50q P+cFAh997rlpgrkv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 19, 2016 5:27:08 PM CEST Deepa Dinamani wrote: > mutex_lock(&sbi->s_alloc_mutex); > lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX; > lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX; > + ktime_get_real_ts(&ts); > udf_time_to_disk_stamp(&lvid->recordingDateAndTime, > - CURRENT_TIME); > + timespec_trunc(ts, sb->s_time_gran)); > lvid->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN); > > lvid->descTag.descCRC = cpu_to_le16( > I think we don't need the timespec_trunc here, and introducing the call might complicate matters in the future. IMHO timespec_trunc() really only makes sense when assigning into an inode timestamp, whereas udf_time_to_disk_stamp() already truncates the resulting nanoseconds to microseconds. Arnd