From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbcF2P0F (ORCPT ); Wed, 29 Jun 2016 11:26:05 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:59820 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbcF2P0C (ORCPT ); Wed, 29 Jun 2016 11:26:02 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, Wan Zongshun , Daniel Lezcano , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Wed, 29 Jun 2016 17:27:53 +0200 Message-ID: <8706947.5rzUDVsB2F@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466851042-22239-5-git-send-email-vw@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <1466851042-22239-5-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:9VqA+OUGJ+J5dFuzxTazIMnDeZCQ3hMkTqd09d+uiFbAhJ7AGne oLD8cUcDdIugtoYd0RjN3xVY0OHQobPlKnIVJ1t6AD0PrH7FhZmMT3qGM5baidVqwM3/15z pu0Ke0bxmp1mvud+vJxSG/sB1CIgQb1gFiPIqv/RwlGXjZk3CKDuHqaBL4XUEIFd2OqUtyL NSbI13LAaz6cUnWpvKXVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:aGnCHytTrpY=:41vhXMTv8/ldtn5x9Mqlxh 38FKokGOprt57asw+EQF2JfAv/jdgF3eBHzoMBBdeeuV6h/5ryN6alBzkNwaH+VgXXA99kXUp lxmhcgCvfD6i0JvXGGC//nadLi5PO6yWz7jEky4AlCfqMwXGg4hLwYurZcVnux6xR/AC5U3HT nj4iV1x9W5UDa24uxt9HF9tU2ytj7g/9lLG5Sp/ieqDr2eMkiaJ9C8jFs1+69RBGPceg2Mgn2 bQu157MJIKOPzMV4Q8jbnldGjI1zuJpQ8XuQAZzF7X81RxwCOn2fYeliF/b0HAZynW1KI8uc7 2ZTVbQSymG5B9m2BxIz/W8agUTCgQ/eWSlKtbmmOnHYZc9M7QknlhwI+klwdu04WRIGrhDW8j /ChGTTiHnmfU4vgEhqmgKZXI43LM6q6e7iW8Y9+JUYuxO2d/j7ZSyvDfVyj8enEzKO4/dT2jL q300mCxPW9cH3uU0SPnD92AC59/Ethr2LM/3sfwxYslA/7Fru4cJEwFzIFPdJA6uojpl/RSkC HWq8TBhlmrLYMKU/9y/GcJfh0u/hF7zF2gFTY2NlbbZvnbTPXrvBVGx0iLG7u5F4OWopcaJ7d daVFuMjfb/D58hSbB2S97hPECNC0c8AfRAApyWJDdn2zyiBRS8fzSUHPS69qOo6M2StuC19A1 QRSvmDnCcyagZERkhzWl5Cv7nqWLjIHjHvWiw2fxJDp+VDUxLZ6OAO5ZiIdVEi7S3P0E2RMsu VoWLpgX5MKHpWva2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > +#define IRQ_WDT W90X900_IRQ(1) > +#define IRQ_WWDT W90X900_IRQ(2) > +#define IRQ_LVD W90X900_IRQ(3) > +#define IRQ_EXT0 W90X900_IRQ(4) > +#define IRQ_EXT1 W90X900_IRQ(5) > +#define IRQ_EXT2 W90X900_IRQ(6) > +#define IRQ_EXT3 W90X900_IRQ(7) > +#define IRQ_EXT4 W90X900_IRQ(8) > +#define IRQ_EXT5 W90X900_IRQ(9) > +#define IRQ_EXT6 W90X900_IRQ(10) I'd suggest dropping the list, the contents are now in the dts. > diff --git a/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h > new file mode 100644 > index 0000000..7a77016 > --- /dev/null > +++ b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h > @@ -0,0 +1,53 @@ > +#ifndef __ASM_ARCH_REGS_AIC_H > +#define __ASM_ARCH_REGS_AIC_H > + > +/*NUC970 AIC regs*/ > + > +#define REG_AIC_SCR1 0x00 > +#define REG_AIC_SCR2 0x04 > +#define REG_AIC_SCR3 0x08 > +#define REG_AIC_SCR4 0x0C > +#define REG_AIC_SCR5 0x10 And like the clk driver, these should all be in the irqchip driver instead of a separate header. > + > +static void __iomem *aic_base; > +static struct irq_domain *aic_domain; > +#define MAKE_HWIRQ(irqnum) (irqnum) The macro appears to be unused. > +static void nuc970_irq_mask(struct irq_data *d) > +{ > + if (d->irq < 32) > + __raw_writel(1 << (d->irq), aic_base + REG_AIC_MDCR); > + else > + __raw_writel(1 << (d->irq - 32), aic_base + REG_AIC_MDCRH); > +} writel() Arnd