From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D4183DBD72 for ; Mon, 4 May 2026 13:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900261; cv=none; b=q6tNcmsZ2nkAOhXdvGkg1GPZMgLYQKwxJnoNO3SL0nPKoGxOl4j+q5lSSelG9ljdaHv4OKn/59GnZXo5sl6HN1FfZac3iEpmdGVaVpw6WC4d6INAfIb2bcso3qTNmbs3A9024iC5NYkkWRu0G6oXoSFZSHkC6MtOmFbHgnQ47F4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900261; c=relaxed/simple; bh=65BCyDO9jtqHt0rIS+TTWdrkvghKnA/Z0GBZ5zaHOzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pYf2NMDvDO0P3Nw9P5HyusROlVdHCMICUgSmCDVtDE0wVlitdhSiPUiA9fO2ziJQsLfRau1Jwp+rdPQ9QSosqpgfJNp6CVXBlrzY/mAfV5uu6j8KSLdpiA1Ta2zMVb4hYlV8aEmFWP8mpNYiUc3h0rh+lVEhqJcVTFfctH9/42o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZSvuHGy9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XMhwT42B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZSvuHGy9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XMhwT42B" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644B4Idk1531315 for ; Mon, 4 May 2026 13:10:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=ZSvuHGy95t9IhfsP U3AUnAAWUZb4mq54JFS6nvzoZ9btK6EbfUg23V7kI56xOv7GPGAzijdIcg4NtuwA QQzmGEQyU/M8acpw5M99WmnZoh9sOA+qPIXl0bAnsEezyx4ZT6VH1emP73U+So1v P7dUn0UWcIkTpQug6+gD66d4Umg7wTExv3+MGH+pzOShYIhqBy74moGYuJ7yqwDm qW8DAN2Nh0Yov6kGScLpG+Pb6VQHKwO1zbNqBJ1kq530dm4W+d0SNFH8E8kP9XW6 SVo8kV2gK42wvtxUL6SkLKEtx02NFmBDUEtCeGR1dxi/jjEP3YV433YmTCMgLyDY E780jA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dwa1enpmk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 13:10:58 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-60fa6cc0c81so367825137.1 for ; Mon, 04 May 2026 06:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777900257; x=1778505057; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=XMhwT42BYOa/tG22c5TqncrG0WSs8tKCsN2doO/JXG8VgUpTHTnSgrdBFk4rSzfJ/s bSbWubMyxaZbQ/J1aoiXx+Ac8BUXJQwkv1O9+6QHcbm8tMzlWacj2HVy1O9TnwZxuJmC 0zOCXYIYB1doyquaS7YVyMsDrl3PEfskfNs5x3rvmmBlNiWQglWeS6irATSTgT8jPEbh DVw3Q++hjcJyuX5AmE8kmRG5blbynWQ1Lrz6Ul0sXjzDy3d3hBBIRdqYHZatQJzZxKyU DER3eEAiaCLU4s/vc9S6TYXaGRFiGud0IfsPCF9RxyAcUi9ZsUEbw/Gkmb6xLybr07lv DEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777900257; x=1778505057; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=efulmdZTea3zB8ep1exl9ROjjEWK80LlBAniNH/PiJ+D738OmukxIPNlnToXBSFm86 6qXKqLiqkbinKD3n5DFw4zIR3lvV+NpzEGgvNt2QjG8d3WTaZVFvPf0dMQbT5GWNB9wx Rm8o8Jgnip3QurDJzhqaB71PGRT+OVwVHdSs2DqqHSEzETUKRoW8DI9YvgkTOfilzqp5 YJMOMNwa7kbl2sZpUlOdYdQtgqJ2bb/co8QqZ5hHm5NLZ+cJht6N+intMBlhKLn33Fgy 5fNJ6Bql21a9yPDtkswdS9rvFWKaThddC5XBbrFh+8GRP0KduxGFdTHr/M6UZurSM3uC ttPg== X-Forwarded-Encrypted: i=1; AFNElJ9XIIJFjYlnIbSzRfJ6o8M7Wjck7k8L396baXQvKZyNivKjlhxccMCY9uQpmBCJ7r7UW9tx/n8pQhABwOg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe//D26nsE/9KGGv0UEgMXMv1SgDX/OnvPnvX8q3MnfVGSVOhZ LeL+j4CttjlS5VGzFWK5XFC6u2lCp2csOJmGK4hRypscysq0h/J/2MjM6b07Vu0wc2TLpqF8rmQ Tk+7BPfHXpdNopZ7sIXDxGuMX7aNWbYtJ07O2sDYTEKgCnmpXhv8m5GeXCPozipAYtGA= X-Gm-Gg: AeBDieuRWaxP3NUxx7FT1nbD6OYzVJMq25H58bdrPUVq2VULsug0BEh+29X5Ul0ppfe mf3YAOYMdFvvW1rFWruFFcpC8RQzNe4pSOz2+qY75mbjTmz0e9K7YMo61NnPKLEi5s88VIJjvUk 2ZdMR4w1bvonfxFEaT5tLit0HRyTm84KdHiEGyEY6a60jpdfQR+B0Q8wooMWWnMeNpOu5lQwVCH upucXN3wXQEWbja/Vy6RQ0SwZ4zIqXzE4g3yf0PFhqkdrWoLplfYsuKlM6zRQjLZh7WASRKsHJv aP1G1MnSYMrJNeCaPcKDKhbtyr9MP3XNcdkoOJdUIeCNse9vRiK1ijxaDMJL4PqPpUkJmC6Uitz gim1Q58ZVHcf8oiHd0UJ7xQhtAatt9/5ryVh+oYV1K7YBp4TOR5X4ip7A3dmSSimwJHPDKMHKy6 qsqqTgd84RdnIKFg== X-Received: by 2002:a05:6122:3611:b0:575:35f9:66b7 with SMTP id 71dfb90a1353d-57535f97091mr279807e0c.3.1777900257441; Mon, 04 May 2026 06:10:57 -0700 (PDT) X-Received: by 2002:a05:6122:3611:b0:575:35f9:66b7 with SMTP id 71dfb90a1353d-57535f97091mr279764e0c.3.1777900256820; Mon, 04 May 2026 06:10:56 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc1ad2d59fcsm149037266b.45.2026.05.04.06.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 06:10:55 -0700 (PDT) Message-ID: <870d16bb-b426-4285-a299-deb09ae90243@oss.qualcomm.com> Date: Mon, 4 May 2026 15:10:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi To: Luca Weiss , Dmitry Baryshkov , Jeff Johnson , Baochen Qiang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Koskovich , Liam Girdwood , Mark Brown , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Balakrishna Godavarthi , Rocky Liao , Johannes Berg , Jeff Johnson , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org References: <20260403-milos-fp6-bt-wifi-v2-0-393322b27c5f@fairphone.com> <20260403-milos-fp6-bt-wifi-v2-7-393322b27c5f@fairphone.com> <4fbs4arx6sez6fffy75ctmzecfvitr6aocau3cczlr2ps2ptld@v7wpa2irsihl> <2514523f-a43f-4470-a69b-3d5175d10385@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NK9iwoYx80EHnSgLMvVF_vn16aBT9C2l X-Proofpoint-GUID: NK9iwoYx80EHnSgLMvVF_vn16aBT9C2l X-Authority-Analysis: v=2.4 cv=e7U2j6p/ c=1 sm=1 tr=0 ts=69f89ae2 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=1iLxIbVeREuL6hqEqU8A:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDE0MCBTYWx0ZWRfXyKNhm+neMErb uDtE7GUTC/8/IXbpKQoX3WQS38tJUVTsrGw5R5FeUOJsLrTXBv5/lEszGwBtQuUISRHUmxklaul 5DRHYv+SSaON00THeYLK1tl2+N2U4iXfZsv5jmyAOG8r7m9WYxXk1T2/0svXb6/grsQHebYCc80 OMaHCXp5ETUldOVr8nXdpZ9YY53csPdI+Ey0Xo2HrzVmX0544gqHgDD3NEVYpSlWxLd0ThfUvsQ aTQa+NLtP8nk7OXKU4EEbj3CxlPWPrXblVVRyMZIvqYdM/ZyB+7775Ir9wsQ6ee6NyaCRGCoaBZ EzxlaN4vHvNDHa2HvKuHHNNu+Fzdo/JP1W7X2QozUcWPmH9yP8qe/gIhksLqeDV7dlODprhYH7+ Ve+MvAFmCBvxcbayPGywQGqDznvLhHNCe01LyC6d0XWKqgYOg2pvCh1HHOHn58fvydGd+AhMyWQ /1h9AmoCCRGswZXtWAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040140 On 5/1/26 11:20 AM, Luca Weiss wrote: > Hi Konrad, > > On Tue Apr 7, 2026 at 3:16 PM CEST, Konrad Dybcio wrote: >> On 4/3/26 9:35 PM, Dmitry Baryshkov wrote: >>> On Fri, Apr 03, 2026 at 03:52:53PM +0200, Luca Weiss wrote: >>>> Configure and enable the WiFi node, and add the required pinctrl to >>>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755. >>>> >>>> Thanks to Alexander Koskovich for helping with the bringup, adding >>>> the missing pinctrl to make the WPSS stop crashing. >>>> >>>> Link: https://lore.kernel.org/linux-arm-msm/DBF7OWAWQ94M.FSCP4DPF8ZJY@fairphone.com/ >>>> Reviewed-by: Dmitry Baryshkov >>>> Signed-off-by: Luca Weiss >>>> --- >>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 ++++++++++++++++++- >>>> 1 file changed, 18 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> index db72418b7195..d8ac495ca7c8 100644 >>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> @@ -242,7 +242,7 @@ wcn6750-pmu { >>>> >>>> clocks = <&rpmhcc RPMH_RF_CLK1>; >>>> >>>> - pinctrl-0 = <&bluetooth_enable_default>; >>>> + pinctrl-0 = <&bluetooth_enable_default>, <&pmk8550_sleep_clk_default>; >>>> pinctrl-names = "default"; >>>> >>>> regulators { >>>> @@ -766,6 +766,17 @@ &pmiv0104_eusb2_repeater { >>>> qcom,tune-usb2-preem = /bits/ 8 <0x6>; >>>> }; >>>> >>>> +&pmk8550_gpios { >>>> + pmk8550_sleep_clk_default: sleep-clk-default-state { >>>> + pins = "gpio5"; >>>> + function = "func1"; >>>> + input-disable; >>>> + output-enable; >>> >>> Hmm, if it's a sleep_clk, should it not be handled via the power >>> sequencer? >> >> If you mean that it may be needed to toggle it with specific timings, >> possibly.. seems that WCN6855 has a "xo-clk" GPIO defined. I requested >> access to some docs that I think should have the answer, hopefully should >> get it soon. > > Did you manage to get anything there yet? Yeah, sorry, it got lost in the sea of emails.. The PDF talks about the electrical requirements of the clock signal and the section titled "Power-up sequence timing" doesn't mention it at all, so my assumption would be "OK so long as it's ticking before you power up the WCN" Konrad