The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: robert.ward114@googlemail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] /dev/mem as optional device + associated tidy up
Date: Sun, 07 Dec 2014 20:35:31 +0100	[thread overview]
Message-ID: <8719187.RB9WVc9E5S@wuerfel> (raw)
In-Reply-To: <1417966835-14012-1-git-send-email-robert.ward114@googlemail.com>

On Sunday 07 December 2014 15:40:32 robert.ward114@googlemail.com wrote:
> From: Rob Ward <robert.ward114@googlemail.com>
> 
> Makes the /dev/mem device optional using the CONFIG_DEVMEM option.
> 
> This brings /dev/mem in line with /dev/kmem so it can de disabled. 
> Disabling /dev/mem is preferable on devices that do not require
> direct access to memory in order to improve security. This is especially
> true on platforms where no restiction is placed on the areas of memory
> that can be accessed(for example mips) without custom modifcations to
> the kernel source.
> 
> The implementation of this functionality declares the mem_fops structure
> as __maybe_unused to eliminate the need for #ifdefs throughout the
> file.
> 
> Follow up changes are present to change CONFIG_DEVKMEM and CONFIG_DEVPORT
> to use __maybe_unused. This simplifies the code and make the
> implementations consistent.
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

      parent reply	other threads:[~2014-12-07 19:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 15:40 [PATCH 0/3] /dev/mem as optional device + associated tidy up robert.ward114
2014-12-07 15:40 ` [PATCH 1/3] drivers: char: mem: Make /dev/mem an optional device robert.ward114
2014-12-07 15:40 ` [PATCH 2/3] drivers: char: mem: Simplify DEVKMEM configuration robert.ward114
2014-12-07 15:40 ` [PATCH 3/3] drivers: char: mem: Simplify DEVPORT configuration robert.ward114
2014-12-07 19:35 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8719187.RB9WVc9E5S@wuerfel \
    --to=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.ward114@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox