From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Li peiyu <579lpy@gmail.com>, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: add threshold events support
Date: Sat, 3 Feb 2024 16:53:33 +0100 [thread overview]
Message-ID: <871e7e7a-c987-4926-957e-5dfdb46d0740@gmail.com> (raw)
In-Reply-To: <20240203144205.GA3727@debian>
On 03.02.24 15:42, Dimitri Fedrau wrote:
> Am Sat, Feb 03, 2024 at 10:30:09AM +0100 schrieb Javier Carrasco:
>> Hi Dimitri,
>>
> Hi Javier,
>
>>> + /* Supported temperature range is from –40 to 125 degree celsius */
>> Should that not be val < -40?
> yes, you are right. Will fix it.
>>> + if (val < -45 || val > 125)
>>> + return -EINVAL;
>>> +
>
> Best regards,
> Dimitri
When at it, could you please rename the hdc3020_id variable you added to
the probe function? It shadows the i2c_device_id global variable (it is
not used in the probe function, but there is no need to use the exact
same name), and given that it is in the hdc3020_probe function,
mentioning the device name again is kind of redundant. Something like
just "id" or "dev_id" would suffice.
Best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-02-03 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 9:05 [PATCH] iio: humidity: hdc3020: add threshold events support Dimitri Fedrau
2024-02-03 9:30 ` Javier Carrasco
2024-02-03 14:42 ` Dimitri Fedrau
2024-02-03 15:53 ` Javier Carrasco [this message]
2024-02-03 16:08 ` Dimitri Fedrau
2024-02-03 9:58 ` Christophe JAILLET
2024-02-03 10:06 ` Javier Carrasco
2024-02-03 14:54 ` Dimitri Fedrau
2024-02-03 14:47 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871e7e7a-c987-4926-957e-5dfdb46d0740@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=579lpy@gmail.com \
--cc=dima.fedrau@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox