From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: wavefront: add suspend and resume support
Date: Wed, 29 Apr 2026 07:52:42 +0200 [thread overview]
Message-ID: <871pfyqpn9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260427-wavefront-pm-v1-1-9c1b6a898673@gmail.com>
On Mon, 27 Apr 2026 17:36:49 +0200,
Cássio Gabriel wrote:
>
> The WaveFront driver still lacks support for suspend and resume
> in both the ISA and PnP driver tables.
>
> Wire the driver into ALSA PM by storing the WSS codec pointer in the card
> private data and adding shared suspend/resume callbacks. Resume cannot
> simply rerun snd_wavefront_start(), because with the default fx_raw=1
> setting that would reset the synth on every resume and discard uploaded
> WaveFront RAM contents.
>
> Cache wavefront.os for PM, probe the ICS2115 after resume and only run
> the full reset/bootstrap path when the board comes back raw. When the
> firmware is still running, refresh the software slot bookkeeping and
> restore the MIDI routing state without forcing a synth reset.
>
> Also quiesce and restart the WaveFront MIDI output timer across suspend
> and resume so active rawmidi output does not race the PM transition.
>
> This restores the card to a usable baseline after resume while preserving
> uploaded samples and programs when the hardware state survives suspend.
> If the board resumes raw, userspace still needs to reload custom synth
> contents.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-04-29 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 15:36 [PATCH] ALSA: wavefront: add suspend and resume support Cássio Gabriel
2026-04-29 5:52 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pfyqpn9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox