From: Thomas Gleixner <tglx@kernel.org>
To: Dmitry Ilvokhin <d@ilvokhin.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [patch 04/14] x86/irq: Make irqstats array based
Date: Tue, 10 Mar 2026 11:15:44 +0100 [thread overview]
Message-ID: <871phsrnvz.ffs@tglx> (raw)
In-Reply-To: <aa8NjoGSgF8Eq_iy@shell.ilvokhin.com>
On Mon, Mar 09 2026 at 18:12, Dmitry Ilvokhin wrote:
> On Wed, Mar 04, 2026 at 07:55:45PM +0100, Thomas Gleixner wrote:
>> + ISS(ICR_READ_RETRY, "RTR", " APIC ICR read retries\n"),
>> + ISS(X86_PLATFORM_IPI, "PLT", " Platform interrupts\n"),
>
> The old code only showed "PLT" when x86_platform_ipi_callback was set,
> but with ISS() this is now unconditional.
>
> Is this intentional?
Yes because I didn't want to add yet another conditional of dubious value.
> [...]
>
>> - seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count));
>> -#if defined(CONFIG_X86_IO_APIC)
>> - seq_printf(p, "%*s: %10u\n", prec, "MIS", atomic_read(&irq_mis_count));
>> + ITS(HYPERV_REENLIGHTMENT, "HRE", " Hyper-V reenlightment interrupts\n"),
>
> HYPERV_REENLIGHTMENT doesn't match the enum (HYPERV_REENLIGHTENMENT).
> This should break the build with CONFIG_HYPERV=y. There is also a same
> typo in text description.
Michael pointed that out already. Fixed locally.
>> + seq_printf(p, "ERR: %10u\n", (unsigned int) atomic_read(&irq_err_count));
>> + if (IS_ENABLED(CONFIG_X86_IO_APIC))
>> + seq_printf(p, "MIS: %10u\n", (unsigned int) atomic_read(&irq_mis_count));
>
> This drops the prec-based alignment for ERR and MIS.
Indeed.
next prev parent reply other threads:[~2026-03-10 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:55 [patch 00/14] genirq: Improve /proc/interrupts for real and add a binary interface Thomas Gleixner
2026-03-04 18:55 ` [patch 01/14] x86/irq: Optimize interrupts decimals printing Thomas Gleixner
2026-03-04 18:55 ` [patch 02/14] genirq/proc: Avoid formatting zero counts in /proc/interrupts Thomas Gleixner
2026-03-09 15:59 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 03/14] genirq/proc: Utilize irq_desc::tot_count to avoid evaluation Thomas Gleixner
2026-03-09 16:04 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 04/14] x86/irq: Make irqstats array based Thomas Gleixner
2026-03-04 22:18 ` Michael Kelley
2026-03-05 15:52 ` Thomas Gleixner
2026-03-09 18:12 ` Dmitry Ilvokhin
2026-03-10 10:15 ` Thomas Gleixner [this message]
2026-03-04 18:55 ` [patch 05/14] genirq: Expose nr_irqs in core code Thomas Gleixner
2026-03-09 18:26 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 06/14] genirq: Cache the condition for /proc/interrupts exposure Thomas Gleixner
2026-03-16 18:46 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 07/14] genirq: Calculate precision only when required Thomas Gleixner
2026-03-16 18:57 ` Dmitry Ilvokhin
2026-03-04 18:56 ` [patch 08/14] genirq: Add rcuref count to struct irq_desc Thomas Gleixner
2026-03-04 18:56 ` [patch 09/14] genirq: Expose irq_find_desc_at_or_after() in core code Thomas Gleixner
2026-03-04 18:56 ` [patch 10/14] genirq/proc: Speed up /proc/interrupts iteration Thomas Gleixner
2026-03-04 18:56 ` [patch 11/14] [RFC] genirq: Cache target CPU for single CPU affinities Thomas Gleixner
2026-03-04 18:56 ` [patch 12/14] [RFC] genirq/proc: Provide binary statistic interface Thomas Gleixner
2026-03-04 18:56 ` [patch 13/14] [RFC] genirq/proc: Provide architecture specific binary statistics Thomas Gleixner
2026-03-04 18:56 ` [patch 14/14] [RFC] x86/irq: Hook up architecture specific stats Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871phsrnvz.ffs@tglx \
--to=tglx@kernel.org \
--cc=d@ilvokhin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox