From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5102036E47E for ; Tue, 10 Mar 2026 10:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773137748; cv=none; b=UYBGNJl9hE4wPedThlR9N9q33/Mu9jJjY9EuOedCfyvUtrKBn0jTphGGzYD0W0jaI4YRehHPD4T/iUgZhq3trq2bNEobZC4YTkWuniTHZYJNII8ob2gDhW6gXXJEZRIWr3X97HwfMY8kibEN0EZjuQsXL/CrVzDuFYTOGgwqaK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773137748; c=relaxed/simple; bh=Zx9iLhAAO1vD2cMKcNMzw3yxCzOQDEtOK4q9mqos/2E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bazoPzAJbWvqh+MeIUISzHx64XcDFT2rcuwCK279YiBHUg+eNmFOqk5iuAqZJlRwuFpPXlbtLdsl5NiOC6vq1A9lZ5SLMgB4hXAIrrFfUzIaZWU48YUwD+VBi8nFBmriDR/kSvdXCn2joiyR2BqXdSX8P05TO1OEYSvoT3tHRKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bsE2sIm0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bsE2sIm0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E8B5C19423; Tue, 10 Mar 2026 10:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773137747; bh=Zx9iLhAAO1vD2cMKcNMzw3yxCzOQDEtOK4q9mqos/2E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bsE2sIm0hgNlaXdmq8/ukk8mWpSfHQvKvBY5nfyh06TIirH/I0l3DTeo3TILlpUQv 0gZ/Z/Tuk5KJb9mLIjIAV2zmHTywoxVNG+jAN0Ax6XGQCMgsTlwbvKi7QB2lf201xs aLHTixET8cDGAWxZVNT3N+MHpFYHv21VyhWs5ZmeEZD0AWBfRVNaJ/HcUAyHjq8lEY gHJHedGWKdeQRRO1LnVxxoaZy3Iulm9tArrIuCrMX4O59Ya0lmyjCeYmIfmSSLCews CW+MYuuB9lf7v/nF0JRkmaY8rC7dedp6dyTe29HaBilgcSdVx2CU9mFUOdceWGQbsi 1Vs7RG+P4W4bA== From: Thomas Gleixner To: Dmitry Ilvokhin Cc: LKML , x86@kernel.org, Neil Horman Subject: Re: [patch 04/14] x86/irq: Make irqstats array based In-Reply-To: References: <20260303150539.513068586@kernel.org> <20260303154548.218256740@kernel.org> Date: Tue, 10 Mar 2026 11:15:44 +0100 Message-ID: <871phsrnvz.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Mar 09 2026 at 18:12, Dmitry Ilvokhin wrote: > On Wed, Mar 04, 2026 at 07:55:45PM +0100, Thomas Gleixner wrote: >> + ISS(ICR_READ_RETRY, "RTR", " APIC ICR read retries\n"), >> + ISS(X86_PLATFORM_IPI, "PLT", " Platform interrupts\n"), > > The old code only showed "PLT" when x86_platform_ipi_callback was set, > but with ISS() this is now unconditional. > > Is this intentional? Yes because I didn't want to add yet another conditional of dubious value. > [...] > >> - seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count)); >> -#if defined(CONFIG_X86_IO_APIC) >> - seq_printf(p, "%*s: %10u\n", prec, "MIS", atomic_read(&irq_mis_count)); >> + ITS(HYPERV_REENLIGHTMENT, "HRE", " Hyper-V reenlightment interrupts\n"), > > HYPERV_REENLIGHTMENT doesn't match the enum (HYPERV_REENLIGHTENMENT). > This should break the build with CONFIG_HYPERV=y. There is also a same > typo in text description. Michael pointed that out already. Fixed locally. >> + seq_printf(p, "ERR: %10u\n", (unsigned int) atomic_read(&irq_err_count)); >> + if (IS_ENABLED(CONFIG_X86_IO_APIC)) >> + seq_printf(p, "MIS: %10u\n", (unsigned int) atomic_read(&irq_mis_count)); > > This drops the prec-based alignment for ERR and MIS. Indeed.