public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Paweł Hofman" <phofman@o2.pl>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	sbinding@opensource.cirrus.com, kailang@realtek.com,
	chris.chiu@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM
Date: Mon, 23 Feb 2026 09:56:13 +0100	[thread overview]
Message-ID: <871pibn8ia.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260222213224.216805-1-phofman@o2.pl>

On Sun, 22 Feb 2026 22:32:24 +0100,
Paweł Hofman wrote:
> 
> On UX7602ZM, the previous quirk (ALC245_FIXUP_CS35L41_SPI_2) left speaker volume behavior incorrect: increasing volume mainly boosted highs while overall loudness stayed nearly flat.
> 
> Use ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS because it also applies the ASUS-specific rear-speaker pin setup and chains the headset-mic fixup on top of CS35L41 SPI amp init, which matches this platform better.

You seem to have forgotten your Signed-off-by tag?
Also, try to fold the lines in the patch description appropriately,
too.

Please resubmit with those corrections.


thanks,

Takashi

      reply	other threads:[~2026-02-23  8:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 21:32 [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM Paweł Hofman
2026-02-23  8:56 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pibn8ia.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=chris.chiu@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phofman@o2.pl \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox