public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM
@ 2026-02-22 21:32 Paweł Hofman
  2026-02-23  8:56 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Paweł Hofman @ 2026-02-22 21:32 UTC (permalink / raw)
  To: perex, tiwai, linux-sound
  Cc: sbinding, kailang, chris.chiu, linux-kernel, Paweł Hofman

On UX7602ZM, the previous quirk (ALC245_FIXUP_CS35L41_SPI_2) left speaker volume behavior incorrect: increasing volume mainly boosted highs while overall loudness stayed nearly flat.

Use ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS because it also applies the ASUS-specific rear-speaker pin setup and chains the headset-mic fixup on top of CS35L41 SPI amp init, which matches this platform better.
---
 sound/hda/codecs/realtek/alc269.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 36053042ca77..3fade4f1a277 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7245,7 +7245,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1043, 0x1f1f, "ASUS H7604JI/JV/J3D", ALC245_FIXUP_CS35L41_SPI_2),
-	SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC245_FIXUP_CS35L41_SPI_2),
+	SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS),
 	SND_PCI_QUIRK(0x1043, 0x1f63, "ASUS P5405CSA", ALC245_FIXUP_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1043, 0x1f92, "ASUS ROG Flow X16", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x1fb3, "ASUS ROG Flow Z13 GZ302EA", ALC287_FIXUP_CS35L41_I2C_2),
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM
  2026-02-22 21:32 [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM Paweł Hofman
@ 2026-02-23  8:56 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-02-23  8:56 UTC (permalink / raw)
  To: Paweł Hofman
  Cc: perex, tiwai, linux-sound, sbinding, kailang, chris.chiu,
	linux-kernel

On Sun, 22 Feb 2026 22:32:24 +0100,
Paweł Hofman wrote:
> 
> On UX7602ZM, the previous quirk (ALC245_FIXUP_CS35L41_SPI_2) left speaker volume behavior incorrect: increasing volume mainly boosted highs while overall loudness stayed nearly flat.
> 
> Use ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS because it also applies the ASUS-specific rear-speaker pin setup and chains the headset-mic fixup on top of CS35L41 SPI amp init, which matches this platform better.

You seem to have forgotten your Signed-off-by tag?
Also, try to fold the lines in the patch description appropriately,
too.

Please resubmit with those corrections.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-23  8:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-22 21:32 [PATCH] ALSA: hda/realtek: use ALC285 rear speaker fixup for ASUS UX7602ZM Paweł Hofman
2026-02-23  8:56 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox