From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660C235CB72 for ; Sun, 22 Feb 2026 22:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771799999; cv=none; b=fboj2qnuqo2k4eaJiyj9WAQUSTbUSLmbxgEKlhsScwwsunmgndzn4LmGr/1zog8DBMezg2SBG1Fj3zXx6KIYvtQgKdNHNGv02if/deulyc/Ta6NtKYFHdgGDnytC3H35IkvBT/egs4F9uWZlZVtGUQ5Te20IlsFsK/jEuKmue4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771799999; c=relaxed/simple; bh=nma4RPD/u9Ma+SO3LZfT6v563KJA90dxcvVdC4tqcBM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=dBAt2lLE2TV92A07kIQTwe0VCgujJ1p9k5qrP+P6H1gnHlQyjFjQJe86alKeNYQMWSbRCL+o+Gc67wWAE3F8ZU1CS44ABe/30s285jWwrQBoX27ei1q37eQRYnguEqfExa7z+bUx7P9K+eM6sTxeWfSGiw5EGpQcPeoYYuE1GKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Le4YbTIZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Le4YbTIZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FF74C2BC87; Sun, 22 Feb 2026 22:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771799999; bh=nma4RPD/u9Ma+SO3LZfT6v563KJA90dxcvVdC4tqcBM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Le4YbTIZbLlwj/LE1cA+wHqwvem4xBHzWsgshVzwjSTF7vZzxQm+A3CdrCfKSX1nw vMHKzWPmyLUXvbafqMeQ8K1sXd71PLT/AJ9B3h7C/YUvVnqVicdiJFDcQIM4YASM5z uo/1+kIoaRDSJghu3AuAWpYetVb/VaAioteu2kbXmCv3/xykK61pij5uyrRRL6LVqQ t5KR6cgLcEX0zoK2otn6LfGrSkXaTDBix+XEUISRlBAcgfr8SDOErHY9b9j0nGShLE Pg/V9H4ybhV/Ey+l87JTcg1Oi5md+VkwJ9Bx6ZDw1FyB7482D3VV3BakpdUNvhlDXf T1bJfVNNZM9YQ== From: Thomas Gleixner To: Meghana Malladi , grzegorz.jaszczyk@linaro.org, maz@kernel.org, rogerq@ti.com, david@lechnology.com, afd@ti.com Cc: linux-kernel@vger.kernel.org, srk@ti.com, Vignesh Raghavendra , Roger Quadros , danishanwar@ti.com, m-malladi@ti.com, Grygorii Strashko , Suman Anna Subject: Re: [PATCH v2 2/3] irqchip/irq-pruss-intc: Fix listed IRQ type in /proc/interrupts In-Reply-To: <20260218093730.3123342-3-m-malladi@ti.com> References: <20260218093730.3123342-1-m-malladi@ti.com> <20260218093730.3123342-3-m-malladi@ti.com> Date: Sun, 22 Feb 2026 23:39:55 +0100 Message-ID: <871picwgg4.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Feb 18 2026 at 15:07, Meghana Malladi wrote: > From: Grygorii Strashko > > The PRUSS INTC driver doesn't have .irq_set_type() callback implemented and > supports only IRQ_TYPE_LEVEL_HIGH. This resulted in the IRQ properties not > being updated properly and the PRUSS INTC IRQs were listed incorrectly in > /proc/interrupts as Edge. That's again incomprehensible word salad. If the driver only supports edge then obviously all interrupts belonging to this chip are marked edge. How should they be listed? > Example: > 218: 0 4b220000.interrupt-controller 26 Edge pru10 That's really useful information because nobody knows how /proc/interrupt output looks like. > Fix this by adding a simple .irq_set_type() implementation which checks the > requested IRQ triggering type. And how does that list the the PRUSS interrupts magically with some other type than edge? > Fixes: 04e2d1e06978 ("irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS interrupts") > Signed-off-by: Grygorii Strashko > Signed-off-by: Suman Anna > Link: https://lore.kernel.org/all/20230919061900.369300-3-danishanwar@ti.com/ > Signed-off-by: MD Danish Anwar > Reviewed-by: Roger Quadros > Signed-off-by: Vignesh Raghavendra > Signed-off-by: Meghana Malladi Amazing how many people it takes to get such a trivial fix to LKML and that none of them noticed that the change log does not make any sense at all. Thanks, tglx