Re: [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Eliav,

On 08/02/2026 at 06:19:15 GMT, Eliav Farber <farbere@amazon.com> wrote:

> This series fixes block protection handling for the following Winbond
> SPI-NOR devices:
>  - w25q256jwm
>  - w25q256jw
>  - w25q64jvm
>
> The devices do not correctly describe their Status Register layout and
> protection capabilities (locking flags, TB bit, BP bit configuration).
> As a result, the spi-nor core rejects protection requests and locking
> operations fail with -EINVAL, e.g.:
>
>   flash_lock -l /dev/mtd29
>   flash_lock: error!: could not lock device: /dev/mtd29
>   error 22 (Invalid argument)
>
> Update the device flags to match the actual hardware behavior so that
> locking and unlocking regions work correctly.
>
> Additionally, enable Dual and Quad read support for w25q64jvm when SFDP
> is not used.
>
> All changes were validated using flash_lock on the affected devices.
>
> Eliav Farber (4):
>   mtd: spi-nor: winbond: Fix locking support for w25q256jwm
>   mtd: spi-nor: winbond: Fix locking support for w25q256jw
>   mtd: spi-nor: winbond: Fix locking support for w25q64jvm
>   mtd: spi-nor: winbond: Enable Dual and Quad support for w25q64jvm
>
>  drivers/mtd/spi-nor/winbond.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)


Looks sensible, I was looking to find Fixes tags but due to the number
of refactorings, these are hard to track, so I'm fine keeping the
commits as they are.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl