From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACAD036606B for ; Mon, 9 Feb 2026 10:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770634320; cv=none; b=Fcmirv3wfzNeu+ClPIWvNRMSYXVKMlXdcvWTtX4cCZgMKlID5y6dbW9gnfXvsWoYtFHDGmVlpHgw4+Q0jyq6uKs3D1ixWCWIs+jbBhdP58E1uzqwQFVKnu7SflCEBX+89uiwamOyWTLze5PH08K7TQEepVnzI4iTxaa9RsbpL7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770634320; c=relaxed/simple; bh=xo54jYync5vsbteq/7KqfWRsnzXi/7DRT+CTm5QjWRQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Mx5VswMDT6mieDE8c0fQQ1Qo5Jl6BlPEeaP7V3Gdco6ayG16aeFEaW+fQ+nKhJVrd9N4+HkT5NVHpy9whcjU5Y2JlHMGWNzK2NRbDOD1Cds6o6S0DzYspfmY3wfVCrHtgzo7iNEOTrDes2v06PbtS90OMn6RQWOKbPknAJUsaVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TyAce8vL; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TyAce8vL" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id A3F71C250FF; Mon, 9 Feb 2026 10:51:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CC99E6074B; Mon, 9 Feb 2026 10:51:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id ECF9E119D220D; Mon, 9 Feb 2026 11:51:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770634311; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=rVRzYmwkvkQtJicW7A0Akip70SHXFog0rxc7Dv/8xPs=; b=TyAce8vLHYeUQ8OHs6R1O9UXO56cxFUYmmRB9SNPd8grn4FRYus98fCo0EzQRP5t0mwn95 Sj5PqqxMQU16UTVR2RZ69d//rgS10tfWg+zF8fPOW3MBlTWmD99eqGpvkWmXbqX+l4L7F1 PDjmy0sXASndKCcsjbMb5B47YoYCllsK/06OK1ak7x0HE12u/dV1Q4U2e5eEkvsMu3mW9u /fDq/9zN4ojgbubIYgTM6CL9pb5oh6tH4wiZ6Tgtu9EmB/C+g3GlIwrokYVN4lWPBl4S8s CjllxoON5Wz+XYeGybHI1r99dXqDAC47xRIHUxTWS84yPTMAGKdNY/PrufIjew== From: Miquel Raynal To: Eliav Farber Cc: , , , , , , Subject: Re: [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads In-Reply-To: <20260208061919.30498-1-farbere@amazon.com> (Eliav Farber's message of "Sun, 8 Feb 2026 06:19:15 +0000") References: <20260208061919.30498-1-farbere@amazon.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 09 Feb 2026 11:51:47 +0100 Message-ID: <871piu196k.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Eliav, On 08/02/2026 at 06:19:15 GMT, Eliav Farber wrote: > This series fixes block protection handling for the following Winbond > SPI-NOR devices: > - w25q256jwm > - w25q256jw > - w25q64jvm > > The devices do not correctly describe their Status Register layout and > protection capabilities (locking flags, TB bit, BP bit configuration). > As a result, the spi-nor core rejects protection requests and locking > operations fail with -EINVAL, e.g.: > > flash_lock -l /dev/mtd29 > flash_lock: error!: could not lock device: /dev/mtd29 > error 22 (Invalid argument) > > Update the device flags to match the actual hardware behavior so that > locking and unlocking regions work correctly. > > Additionally, enable Dual and Quad read support for w25q64jvm when SFDP > is not used. > > All changes were validated using flash_lock on the affected devices. > > Eliav Farber (4): > mtd: spi-nor: winbond: Fix locking support for w25q256jwm > mtd: spi-nor: winbond: Fix locking support for w25q256jw > mtd: spi-nor: winbond: Fix locking support for w25q64jvm > mtd: spi-nor: winbond: Enable Dual and Quad support for w25q64jvm > > drivers/mtd/spi-nor/winbond.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks sensible, I was looking to find Fixes tags but due to the number of refactorings, these are hard to track, so I'm fine keeping the commits as they are. Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l