From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47EC2F2603 for ; Wed, 3 Dec 2025 11:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759917; cv=none; b=PVe5W1vzLM/5u/diWjiWzik5UW+pMFcB6Z9Mu48MMYLvkSG39w0Ruv7A+nTqqJVns8oRV3JgtzM+d/tMaeHvxguDxvfUinyVsGDFL8rpBJJHXjbNAtBnZpzaQIkPi0wlSBfjm+HR9wnHnfaH+rTm+h0LeWo1YjXWrWRDQ2GQ8WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759917; c=relaxed/simple; bh=ZsuShzlvrIncoG6iaWogXNnZZBAlN8E/IqA4m0xRHa8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=GtZgsgB2KMzjsGf6P5v29SsRujejm5GL/az/AfUsELuPzFxPiQveC6wtFjkKrC/BXXx7gVq+ZqTMup07pQStXM18Nxz5946Ivz/CvkROPjd6gOuJ0yyqQZt0M8Div/HXmu/YR9aqP9kLbVELMaM85DUHVK8g+29Az5kNvH1GKZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UxDGhbRd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XXq43dyL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UxDGhbRd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XXq43dyL" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3AkZ6B1428308 for ; Wed, 3 Dec 2025 11:05:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=NyEOi7qw9mdk/GOLL2dAFFxp 5HoclXJt2QNJj2O/F1E=; b=UxDGhbRdJ2oPbDL9biErciPNxOGQFM3ekpADN5cR Xpv1JuDlPjUhLTijorpZub/SasIoXu9glpuVGLFwT5fgZF7N4YNPcOegKwOGsJ1b dy5J7jhyLojRgQgTn9fuB10E0OPw+stPC1cDD39c3WGgDSzxCUxXLmVi/7yzy7mA 2qWN21mR4ZfkOftA+IQ53RLROljkqBsYPYaUX0ciXGfHP4jpYYdMUG80N8BLa+ro CatUZSIa1oGLN7NsLlQH3azEoYUqny9np0f2Wg0NqspidyHQ4RiB2V5oye/0HEfb 7qWVWYois8eCRsrWwOt2qQGUyj9rP+PzIlM7BYkh7z4qaA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ate0js8xc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 11:05:14 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b245c49d0cso475154685a.3 for ; Wed, 03 Dec 2025 03:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764759914; x=1765364714; darn=vger.kernel.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NyEOi7qw9mdk/GOLL2dAFFxp5HoclXJt2QNJj2O/F1E=; b=XXq43dyLjvrPi2ErDkxXcRdo3uNmQ7G0Ky8JgrYh19Vnwi23JdqmG5/BDGqbcAGHo8 eYlejWIYUDk+ag9HpSTov+XpgAVw43yriMq89KTjyqMgH9lK5W/kKTTPpCPGwBpzlNuG BBIynveanoaeWCaFdMOr5rLugievoN38p+MdgDOg8tCLH4olnpPFV2wcZ8pFXxiYjuAT mTtsHfmLuCNcjEDGgiXE2bwHX4sP38H3gbIbJUuDTsz+Yf9P3WwOC8TrgfVZPPnH3aWk TNMOZXsp4jUs+3JyvebtbBtWRJ8amtunXkx0Ad0Ri9TW1Ps1NgJzfRRkrM7OHHqBHg3b vtxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764759914; x=1765364714; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NyEOi7qw9mdk/GOLL2dAFFxp5HoclXJt2QNJj2O/F1E=; b=IskrwGEOnyriwXsZ962jWRrqzcgqqz68DtZZ/XPK0i2jUmqh7Tucbmnm5SzFP9Mss6 LW0K1vb+/1VHbmPDSayJLzODDbwPL4OsbK+q1ZWpZJFPcmNiNPMjwBwROY50y2g5vWVG QQlVPqIyX+tlE9thLtIx46u6CFnJs+ZPPHwGU1l3+sjSKHE20zC0Bix9Qxvk8cfZz/6+ 88B80PvsyuYCSaq6pic56KOP1cLtmLpitXCEnBQfXybqUBN8wzvvgt23k1cr9PHBcPBA TIrC0SRkzdlfZYdUbzWMa9pgLpN3QfMYxP6s0Ur7bQAmPDaCzRwkqt3UH3//nKXfYMWP NG6g== X-Forwarded-Encrypted: i=1; AJvYcCWAOUCS6SPIuc+3ScXTePac1RlXjUeUWqaoHOpKRP6TTA7KfH2oCUdqOgIaglwQzSxPAJHQpMnB82LrwUU=@vger.kernel.org X-Gm-Message-State: AOJu0YwtHv9xvoXi+BD3gWS9ZJEC99CWbRsaMsqN5oax4LdumuqffiBF bt+Jqh+GoiyDTYletzRwqQtDF3v7tyBcoMef0QPuChflcEyyJKWrffWeKSvZmJKB5FgGavD1mOK Ub+Uei1Dgpglq9ziijkXI6Z01IHLRh0ZsFqA87OjDvwBNNrMSuos6MIo2OH+Y6nDHKoXRxvhdDy A= X-Gm-Gg: ASbGncv+xKFTgrC2P3nioZjdv/mityoAbu+DeUxtcQPojndvzNQ++TnYDRyeLmDkjr7 JEKBqT4eDWXC4y1RpnOT+5eKOupxXjP65z1N/AApokZD/PDnXSczS5L5TbSHmMLj6apo/TGKOI4 A6Ks8Lx1aqCQKVUHqb3Bt3wkejUZ2sKqaDrbBFgXq3CPPsejJkQ3Oiyp4ay1ws7sfR7BsZOXdvz 2uGNWvuR1vZJbXrfMMNpHYBC2RkJdO7Qy7/ifxNqElzZT03tTpLkgP4f4c2Vj2XMhcZ763/QM/m QWl2sMY2L2nArNa/mWz7+0EMRVFiXLJ6kBMcCfFPNdTKrp727SScCuUsec3byzd7Ll65hJsVfmq 2XvP5YgdcEaUsN79SHXngk0WL X-Received: by 2002:a05:620a:1992:b0:8b3:14dc:4821 with SMTP id af79cd13be357-8b5e535ddedmr199928385a.3.1764759913769; Wed, 03 Dec 2025 03:05:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGP7UTYPI4uM8hl2T0zpyn953VeLitq0+SJ1TZI0OWnnywh4vDi4wppwYKVpl7Kowmqks+WbQ== X-Received: by 2002:a05:620a:1992:b0:8b3:14dc:4821 with SMTP id af79cd13be357-8b5e535ddedmr199923685a.3.1764759913285; Wed, 03 Dec 2025 03:05:13 -0800 (PST) Received: from localhost ([2a01:4b00:b703:c200:1ac0:4dff:fe39:5426]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4792a79dd0esm42285525e9.4.2025.12.03.03.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:05:12 -0800 (PST) From: Punit Agrawal To: Sudeep Holla Cc: Punit Agrawal , jassisinghbrar@gmail.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jamie Iles Subject: Re: [PATCH] mailbox: pcc: don't zero error register In-Reply-To: <20251127-cherubic-chicken-of-honeydew-075eac@sudeepholla> (Sudeep Holla's message of "Thu, 27 Nov 2025 14:37:45 +0000") References: <20251105144229.467089-1-punit.agrawal@oss.qualcomm.com> <20251127-cherubic-chicken-of-honeydew-075eac@sudeepholla> Date: Wed, 03 Dec 2025 11:05:12 +0000 Message-ID: <871plbn7vb.fsf@stealth> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA4NyBTYWx0ZWRfX5Mr5g0kw8CY5 ffBf5JR5Dx10YaqJWj/KRivM4V92veq6S/d0w+ouCCk1QMnTs6YgnotoK/26S/7NwZpVrX0f96t T6y719fDzUcbO7TMRl5lOGhpxavNxaS7V8UomZgV/vx+phG1BLTFwTWX6zBSLd449o10JxNaAHX 3EF4NJ2jHNzD3T9BfNNLrTDAwNmDZXsrgVb52upn9shy4R678vYf7LL3PksFvSiqFKG+tMh5fVT Gc3DDD8Rh1+PURhlU42yelZDv8C5tHd/26DL/1ezjwS98IZP2PvBSeWjWUUxR58njxrMSpNrov2 dxexVP+L2coDTXj+YoGo6REx/d2u/pUT/kbFhzCqiytOioP4QOTwE8FveUXiJbwNgaDYfnpNpSk 47c5BxVJEQjPIm7WX9m1bI1lw2iGyQ== X-Proofpoint-GUID: qhj7LZiSkci7O88x7QmJRKjqCV4PoEYK X-Authority-Analysis: v=2.4 cv=cOHtc1eN c=1 sm=1 tr=0 ts=6930196a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=qiwrPN6s67ThHlttQ34A:9 a=bTQJ7kPSJx9SKPbeHEYW:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: qhj7LZiSkci7O88x7QmJRKjqCV4PoEYK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030087 Sudeep Holla writes: > On Wed, Nov 05, 2025 at 02:42:29PM +0000, Punit Agrawal wrote: >> From: Jamie Iles >> >> The error status mask for a type 3/4 subspace is used for reading the >> error status, and the bitwise inverse is used for clearing the error >> with the intent being to preserve any of the non-error bits. However, >> we were previously applying the mask to extract the status and then >> applying the inverse to the result which ended up clearing all bits. >> >> Instead, store the inverse mask in the preserve mask and then use that >> on the original value read from the error status so that only the error >> is cleared. >> >> Fixes: c45ded7e1135 ("mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4)") > > Good catch! > > Reviewed-by: Sudeep Holla Thanks! It looks like Jassi picked up the patch as a fix for v6.18.