From: Sam James <sam@gentoo.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Richard Henderson <richard.henderson@linaro.org>,
Matt Turner <mattst88@gmail.com>, Stian Halseth <stian@itx.no>,
Magnus Lindholm <linmag7@gmail.com>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: don't reference obsolete termio struct for TC* constants
Date: Mon, 01 Dec 2025 03:59:55 +0000 [thread overview]
Message-ID: <871pleyhqc.fsf@gentoo.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2512010346580.36486@angie.orcam.me.uk>
"Maciej W. Rozycki" <macro@orcam.me.uk> writes:
> On Thu, 2 Oct 2025, Sam James wrote:
>
>> Similar in nature to ab107276607af90b13a5994997e19b7b9731e251. glibc-2.42
>> drops the legacy termio struct, but the ioctls.h header still defines some
>> TC* constants in terms of termio (via sizeof). Hardcode the values instead.
>>
>> This fixes building Python for example, which falls over like:
>> ./Modules/termios.c:1119:16: error: invalid application of 'sizeof' to incomplete type 'struct termio'
>>
>> Link: https://bugs.gentoo.org/961769
>> Link: https://bugs.gentoo.org/962600
>> Co-authored-by: Stian Halseth <stian@itx.no>
>> Co-authored-by: Magnus Lindholm <linmag7@gmail.com>
>> Signed-off-by: Sam James <sam@gentoo.org>
>
> FWIW, the documented tag for co-authors is Co-developed-by: and you're
> supposed to collect corresponding Signed-off-by: tags from each of them
> too. Cf. <Documentation/process/submitting-patches.rst> and the examples
> there.
Thanks, though I'd say I was more being gracious here and that it's not
strictly required to have them here at all.
Anyway, Magnus, I can resend with just my Signed-off-by (and nothing
else) if you like, or can you do that in your tree?
>
> Maciej
next prev parent reply other threads:[~2025-12-01 4:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 23:00 [PATCH] alpha: don't reference obsolete termio struct for TC* constants Sam James
2025-10-01 23:00 ` [PATCH] sparc: " Sam James
2025-10-19 19:18 ` Sam James
2026-01-14 9:20 ` Andreas Larsson
2026-02-04 13:02 ` John Paul Adrian Glaubitz
2026-02-04 13:40 ` [PATCH v4] " Sam James
2026-02-06 10:39 ` Andreas Larsson
2025-10-19 19:18 ` [PATCH] alpha: " Sam James
2025-11-29 16:31 ` Magnus Lindholm
2025-11-29 17:59 ` Magnus Lindholm
2025-12-01 3:50 ` Maciej W. Rozycki
2025-12-01 3:59 ` Sam James [this message]
2025-12-01 6:34 ` Magnus Lindholm
2025-12-01 6:40 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pleyhqc.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=stian@itx.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox