Re: [PATCH] docs: sphinx: add missing SPDX tags

[Jonathan Corbet <corbet@lwn.net>]

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Several Sphinx extensions and tools are missing SPDX tags.
> Add them.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  Documentation/sphinx/cdomain.py           | 1 +
>  Documentation/sphinx/kernel_include.py    | 1 +
>  Documentation/sphinx/kerneldoc.py         | 1 +
>  Documentation/sphinx/kfigure.py           | 1 +
>  Documentation/sphinx/load_config.py       | 1 +
>  Documentation/sphinx/min_requirements.txt | 1 +
>  Documentation/sphinx/parse-headers.pl     | 5 ++++-
>  Documentation/sphinx/requirements.txt     | 1 +
>  Documentation/sphinx/rstFlatTable.py      | 1 +
>  9 files changed, 12 insertions(+), 1 deletion(-)

I've applied this, but the patch led me to wonder...

> diff --git a/Documentation/sphinx/cdomain.py b/Documentation/sphinx/cdomain.py
> index e8ea80d4324c..3dc285dc70f5 100644
> --- a/Documentation/sphinx/cdomain.py
> +++ b/Documentation/sphinx/cdomain.py
> @@ -1,4 +1,5 @@
>  # -*- coding: utf-8; mode: python -*-

Do we really need these lines?  UTF8 should be the default almost
anywhere, and Emacs understands that a .py file will require Python
mode...

Thanks,

jon