From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Santhosh Kumar K <s-k6@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Steam Lin <stlin2@winbond.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/21] mtd: spinand: winbond: Rename DTR variants
Date: Wed, 02 Apr 2025 18:57:05 +0200 [thread overview]
Message-ID: <871puaqz6m.fsf@bootlin.com> (raw)
In-Reply-To: <3ebd53ef-c7fd-4c8c-96f3-32e97b355b6b@linaro.org> (Tudor Ambarus's message of "Wed, 2 Apr 2025 16:19:00 +0100")
Hello Tudor,
First, thanks a lot for the time spent reviewing, much appreciated.
On 02/04/2025 at 16:19:00 +01, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
> Hi, Miquel,
>
> On 3/7/25 3:08 PM, Miquel Raynal wrote:
>> -static SPINAND_OP_VARIANTS(read_cache_dtr_variants,
>> +static SPINAND_OP_VARIANTS(read_cache_dual_quad_dtr_variants,
>
> why not read_cache_single_dual_quad_dtr_variants? I see single dtr too
> in the supported ops.
That's true, but single modes are literally always supported, so it is
not very discriminant, and here my goal is to differentiate the variants
supported by the dual/quad chips vs. the variants supported by the octal
chips (which are not capable of dual/quad transfers). What do you think?
next prev parent reply other threads:[~2025-04-02 16:57 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 15:08 [PATCH 00/21] mtd: spinand: Add octal support Miquel Raynal
2025-03-07 15:08 ` [PATCH 01/21] mtd: spinand: Use more specific naming for the reset op Miquel Raynal
2025-03-07 15:38 ` Tudor Ambarus
2025-03-07 15:45 ` Miquel Raynal
2025-03-10 10:14 ` Tudor Ambarus
2025-03-19 17:32 ` Miquel Raynal
2025-03-20 8:08 ` Tudor Ambarus
2025-03-20 11:31 ` Miquel Raynal
2025-03-20 12:03 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 02/21] mtd: spinand: Use more specific naming for the write enable/disable op Miquel Raynal
2025-03-07 15:39 ` Tudor Ambarus
2025-03-07 15:49 ` Miquel Raynal
2025-03-20 12:22 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 03/21] mtd: spinand: Use more specific naming for the read ID op Miquel Raynal
2025-03-07 15:40 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 04/21] mtd: spinand: Use more specific naming for the get/set feature ops Miquel Raynal
2025-03-07 15:42 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 05/21] mtd: spinand: Use more specific naming for the erase op Miquel Raynal
2025-03-07 15:45 ` Tudor Ambarus
2025-03-07 16:03 ` Miquel Raynal
2025-03-20 12:23 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 06/21] mtd: spinand: Use more specific naming for the page read op Miquel Raynal
2025-03-20 12:28 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 07/21] mtd: spinand: Use more specific naming for the (single) read from cache ops Miquel Raynal
2025-04-02 15:05 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 08/21] mtd: spinand: Use more specific naming for the (dual output) " Miquel Raynal
2025-04-02 15:06 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 09/21] mtd: spinand: Use more specific naming for the (dual IO) " Miquel Raynal
2025-04-02 15:07 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 10/21] mtd: spinand: Use more specific naming for the (quad output) " Miquel Raynal
2025-04-02 15:07 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 11/21] mtd: spinand: Use more specific naming for the (quad IO) " Miquel Raynal
2025-04-02 15:08 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 12/21] mtd: spinand: Use more specific naming for the program execution op Miquel Raynal
2025-04-02 15:12 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 13/21] mtd: spinand: Use more specific naming for the (single) program load op Miquel Raynal
2025-04-02 15:13 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 14/21] mtd: spinand: Use more specific naming for the (quad) " Miquel Raynal
2025-04-02 15:13 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 15/21] mtd: spinand: winbond: Rename DTR variants Miquel Raynal
2025-04-02 15:19 ` Tudor Ambarus
2025-04-02 16:57 ` Miquel Raynal [this message]
2025-04-03 6:19 ` Tudor Ambarus
2025-04-03 8:53 ` Miquel Raynal
2025-04-03 9:48 ` Tudor Ambarus
2025-03-07 15:08 ` [PATCH 16/21] mtd: spinand: winbond: Add support for W35N01JW in single mode Miquel Raynal
2025-04-02 15:22 ` Tudor Ambarus
2025-04-02 17:06 ` Miquel Raynal
2025-03-07 15:08 ` [PATCH 17/21] mtd: spinand: Define octal read from cache operations Miquel Raynal
2025-03-07 15:08 ` [PATCH 18/21] mtd: spinand: winbond: Add octal read support Miquel Raynal
2025-03-07 15:08 ` [PATCH 19/21] mtd: spinand: Define octal load to cache operations Miquel Raynal
2025-03-07 15:08 ` [PATCH 20/21] mtd: spinand: winbond: Add octal program support Miquel Raynal
2025-03-07 15:08 ` [PATCH 21/21] mtd: spinand: winbond: Add support for W35N02JW and W35N02JW chips Miquel Raynal
2025-04-02 15:25 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871puaqz6m.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=s-k6@ti.com \
--cc=stlin2@winbond.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox